'Re: Review Request 125643: Databases: Use QByteArray::fromRawData when passing data to a codec'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 125643: Databases: Use QByteArray::fromRawData when passing data to a codec
From:       "Vishesh Handa" <me () vhanda ! in>
Date:       2015-10-18 22:11:06
Message-ID: 20151018221106.14267.36597 () mimi ! kde ! org
[Download RAW message or body]

--===============4862143998050630050==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125643/
-----------------------------------------------------------

(Updated Oct. 18, 2015, 10:11 p.m.)

Status
------

This change has been marked as submitted.

Review request for Baloo and Igor Poboiko.

Changes
-------

Submitted with commit c67546c4fc8c77d502895cdd240126542e105946 by Vishesh Handa to \
branch master.

Repository: baloo

Description
-------

All 3 codecs seem to always copy the data on decoding. We can avoid the
    extra copy over here by using QByteArray::fromRawData.

Diffs
-----

  src/engine/documentdb.cpp 71c2f62 
  src/engine/positiondb.cpp 032192e 
  src/engine/postingdb.cpp 3045d42 

Diff: https://git.reviewboard.kde.org/r/125643/diff/

Testing
-------

Thanks,

Vishesh Handa

--===============4862143998050630050==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125643/">https://git.reviewboard.kde.org/r/125643/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo and Igor Poboiko.</div>
<div>By Vishesh Handa.</div>

<p style="color: grey;"><i>Updated Oct. 18, 2015, 10:11 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit c67546c4fc8c77d502895cdd240126542e105946 by \
Vishesh Handa to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">All 3 codecs seem to always copy the data on decoding. \
We can avoid the  extra copy over here by using QByteArray::fromRawData.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/engine/documentdb.cpp <span style="color: grey">(71c2f62)</span></li>

 <li>src/engine/positiondb.cpp <span style="color: grey">(032192e)</span></li>

 <li>src/engine/postingdb.cpp <span style="color: grey">(3045d42)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125643/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4862143998050630050==--

[Attachment #3 (text/plain)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 