[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.
From: "Xuetian Weng" <wengxt () gmail ! com>
Date: 2015-10-09 17:06:48
Message-ID: 20151009170648.17685.89249 () mimi ! kde ! org
[Download RAW message or body]
--===============6354588265371108150==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Oct. 9, 2015, 11:49 a.m., Emmanuel Pescosta wrote:
> > Should fix bug 348902 :)
I don't think it's the same bug. The bug that I tries to fixed here is introduced \
between 5.14 - 5.15.
- Xuetian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125544/#review86541
-----------------------------------------------------------
On Oct. 9, 2015, 11:21 a.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125544/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2015, 11:21 a.m.)
>
>
> Review request for Baloo, Release Team and Vishesh Handa.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> The bug is obvious, old code uses limit instead of (limit > 0), which gracefully \
> handles limit < 0 case (means everything).
> After offset is introduced, limit < 0 case is not handled properly.
>
> This patch contains following changes:
> 1. make offset uint, m_offset is uint in Query already.
> 2. handle limit < 0 case properly.
>
>
> Diffs
> -----
>
> src/lib/searchstore.h 17b4263
> src/lib/searchstore.cpp a2e7749
>
> Diff: https://git.reviewboard.kde.org/r/125544/diff/
>
>
> Testing
> -------
>
> baloosearch:/ doesn't return anything because of this, now it properly returns \
> result.
>
> Thanks,
>
> Xuetian Weng
>
>
--===============6354588265371108150==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125544/">https://git.reviewboard.kde.org/r/125544/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 9th, 2015, 11:49 a.m. UTC, <b>Emmanuel \
Pescosta</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Should fix bug 348902 :)</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't think it's the same bug. The bug that I tries to fixed here is introduced \
between 5.14 - 5.15.</p></pre> <br />
<p>- Xuetian</p>
<br />
<p>On October 9th, 2015, 11:21 a.m. UTC, Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo, Release Team and Vishesh Handa.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Oct. 9, 2015, 11:21 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The bug is obvious, old code uses limit instead of \
(limit > 0), which gracefully handles limit < 0 case (means everything).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">After offset is introduced, limit < 0 case is not handled properly.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch contains following changes: 1. make offset \
uint, m_offset is uint in Query already. 2. handle limit < 0 case \
properly.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">baloosearch:/ doesn't return anything because of this, \
now it properly returns result.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/searchstore.h <span style="color: grey">(17b4263)</span></li>
<li>src/lib/searchstore.cpp <span style="color: grey">(a2e7749)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125544/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6354588265371108150==--
[Attachment #3 (text/plain)]
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic