[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 125496: i18n fixes for balooctl config
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2015-10-03 0:32:56
Message-ID: 20151003003256.27965.43118 () mimi ! kde ! org
[Download RAW message or body]
--===============4439890457895189677==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125496/#review86265
-----------------------------------------------------------
Ship it!
- Vishesh Handa
On Oct. 2, 2015, 9:29 p.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125496/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2015, 9:29 p.m.)
>
>
> Review request for Baloo, Pinak Ahuja and Vishesh Handa.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> - add missing i18n translation calls;
> - use i18n arguments instead of word puzzles;
> - more consistent wording;
>
>
> A bit late in the cycle close the release, at least for the 3rd point; partially \
> the 2nd as the messages landed quite late already, but at least the first point \
> should be fine.
>
> Diffs
> -----
>
> src/tools/balooctl/configcommand.cpp dbda4d1
>
> Diff: https://git.reviewboard.kde.org/r/125496/diff/
>
>
> Testing
> -------
>
> Compiles, the strings are properly shown with the right arguments
>
>
> Thanks,
>
> Luigi Toscano
>
>
--===============4439890457895189677==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125496/">https://git.reviewboard.kde.org/r/125496/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Vishesh Handa</p>
<br />
<p>On October 2nd, 2015, 9:29 p.m. UTC, Luigi Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo, Pinak Ahuja and Vishesh Handa.</div>
<div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated Oct. 2, 2015, 9:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">add missing i18n \
translation calls;</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">use i18n arguments instead of word \
puzzles;</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">more consistent wording;</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">A bit late in the cycle close the release, at least \
for the 3rd point; partially the 2nd as the messages landed quite late already, but \
at least the first point should be fine.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiles, the strings are properly shown with the \
right arguments</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/tools/balooctl/configcommand.cpp <span style="color: \
grey">(dbda4d1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125496/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4439890457895189677==--
[Attachment #3 (text/plain)]
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic