[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 125481: Port balooctl check to work with new architecture
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2015-10-02 15:42:53
Message-ID: 20151002154253.27965.71719 () mimi ! kde ! org
[Download RAW message or body]
--===============6664156501421361525==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125481/#review86244
-----------------------------------------------------------
Ship it!
src/file/unindexedfileiterator.cpp (line 97)
<https://git.reviewboard.kde.org/r/125481/#comment59437>
In the future lets implement a function to fetch both the ctime and mtime in one \
go. They are internally save in the same btree, so it would be more efficient.
src/file/unindexedfileiterator.cpp (line 101)
<https://git.reviewboard.kde.org/r/125481/#comment59438>
Maybe we should update UnindexerFileIterator to tell us what parts need to be \
indexed. We're indexing the xattr each time, even though they might not have changed. \
Ditto with filename.
Anyway, this entire process is a rare case and it makes more sense to optimize \
for the common ones.
- Vishesh Handa
On Oct. 2, 2015, 2:57 p.m., Pinak Ahuja wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125481/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2015, 2:57 p.m.)
>
>
> Review request for Baloo and Vishesh Handa.
>
>
> Bugs: 353011
> http://bugs.kde.org/show_bug.cgi?id=353011
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Add a new Runnable which checks for unindexed files and indexes them.
>
>
> Diffs
> -----
>
> src/file/CMakeLists.txt 306a211
> src/file/fileindexscheduler.h 1479063
> src/file/fileindexscheduler.cpp 5bb55ea
> src/file/indexerstate.h 8032280
> src/file/unindexedfileindexer.h PRE-CREATION
> src/file/unindexedfileindexer.cpp PRE-CREATION
> src/file/unindexedfileiterator.cpp bb54da3
> src/tools/balooctl/main.cpp 305c82b
>
> Diff: https://git.reviewboard.kde.org/r/125481/diff/
>
>
> Testing
> -------
>
> Manual testing: created a new file with baloo_file killed. Ran baloo_file and then \
> balooctl check, new file was indexed.
>
> Thanks,
>
> Pinak Ahuja
>
>
--===============6664156501421361525==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125481/">https://git.reviewboard.kde.org/r/125481/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125481/diff/3/?file=409412#file409412line97" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/file/unindexedfileiterator.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
UnIndexedFileIterator::shouldIndex(const QString& filePath, const QString& \
mimetype)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">97</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> \
<span class="p">(</span><span class="n">mTime</span> <span class="o">!=</span> <span \
class="n">fileInfo</span><span class="p">.</span><span \
class="n">lastModified</span><span class="p">().</span><span \
class="n">toTime_t</span><span class="p">())</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">97</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">quint32</span> <span \
class="n">cTime</span> <span class="o">=</span> <span \
class="n">m_transaction</span><span class="o">-></span><span \
class="n">documentCTime</span><span class="p">(</span><span \
class="n">fileId</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In \
the future lets implement a function to fetch both the ctime and mtime in one go. \
They are internally save in the same btree, so it would be more efficient.</p></pre> \
</div> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125481/diff/3/?file=409412#file409412line101" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/file/unindexedfileiterator.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
UnIndexedFileIterator::shouldIndex(const QString& filePath, const QString& \
mimetype)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">98</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="nb">true</span><span \
class="p">;</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">101</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span \
class="nb">true</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe \
we should update UnindexerFileIterator to tell us what parts need to be indexed. \
We're indexing the xattr each time, even though they might not have changed. Ditto \
with filename.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Anyway, this entire process is a rare \
case and it makes more sense to optimize for the common ones.</p></pre> </div>
</div>
<br />
<p>- Vishesh Handa</p>
<br />
<p>On Octubre 2nd, 2015, 2:57 p.m. UTC, Pinak Ahuja wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Pinak Ahuja.</div>
<p style="color: grey;"><i>Updated Oct. 2, 2015, 2:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=353011">353011</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Add a new Runnable which checks for unindexed files \
and indexes them.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Manual testing: created a new file with baloo_file \
killed. Ran baloo_file and then balooctl check, new file was indexed.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/file/CMakeLists.txt <span style="color: grey">(306a211)</span></li>
<li>src/file/fileindexscheduler.h <span style="color: grey">(1479063)</span></li>
<li>src/file/fileindexscheduler.cpp <span style="color: grey">(5bb55ea)</span></li>
<li>src/file/indexerstate.h <span style="color: grey">(8032280)</span></li>
<li>src/file/unindexedfileindexer.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/file/unindexedfileindexer.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/file/unindexedfileiterator.cpp <span style="color: \
grey">(bb54da3)</span></li>
<li>src/tools/balooctl/main.cpp <span style="color: grey">(305c82b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125481/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6664156501421361525==--
[Attachment #3 (text/plain)]
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic