[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 125429: Baloo: Fix dbus warnings
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2015-09-30 16:42:53
Message-ID: 20150930164253.16344.82306 () mimi ! kde ! org
[Download RAW message or body]
--===============6586832039708732395==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 29, 2015, 2:24 p.m., Pinak Ahuja wrote:
> > src/file/filecontentindexer.cpp, line 84
> > <https://git.reviewboard.kde.org/r/125429/diff/1/?file=408580#file408580line84>
> >
> > Wouldn't this slot be executed in the main thread? We most probably don't need \
> > this.
I'm confused. We do need it since dbus signals need to be emitted in the main thread.
- Vishesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125429/#review86113
-----------------------------------------------------------
On Sept. 30, 2015, 4:41 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125429/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2015, 4:41 p.m.)
>
>
> Review request for Baloo and Pinak Ahuja.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Fix dbus warnings
>
> We cannot emit dbus signals from a different thread than the thread the
> object has an affinity to.
>
>
> Diffs
> -----
>
> src/file/filecontentindexer.cpp 4323c3f
>
> Diff: https://git.reviewboard.kde.org/r/125429/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vishesh Handa
>
>
--===============6586832039708732395==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125429/">https://git.reviewboard.kde.org/r/125429/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 29th, 2015, 2:24 p.m. UTC, <b>Pinak \
Ahuja</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125429/diff/1/?file=408580#file408580line84" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/file/filecontentindexer.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
FileContentIndexer::run()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">84</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QMetaObject</span><span class="o">::</span><span \
class="n">invokeMethod</span><span class="p">(</span><span class="k">this</span><span \
class="p">,</span> <span class="s">"indexingFile"</span><span \
class="p">,</span> <span class="n">Qt</span><span class="o">::</span><span \
class="n">QueuedConnection</span><span class="p">,</span> <span \
class="n">Q_ARG</span><span class="p">(</span><span class="n">QString</span><span \
class="p">,</span> <span class="n">filePath</span><span \
class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Wouldn't this slot be executed in the main thread? We most probably don't \
need this.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I'm confused. We do need it since dbus signals need to be emitted in the \
main thread.</p></pre> <br />
<p>- Vishesh</p>
<br />
<p>On September 30th, 2015, 4:41 p.m. UTC, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo and Pinak Ahuja.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Sept. 30, 2015, 4:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fix dbus warnings</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div \
class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">We \
cannot emit dbus signals from a different thread than the thread the object has an \
affinity to. </pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/file/filecontentindexer.cpp <span style="color: grey">(4323c3f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125429/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6586832039708732395==--
[Attachment #3 (text/plain)]
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic