[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 124085: FileMetaDataProvider: Check if indexing disabled before calling IndexedDa
From: "Wolfgang Bauer" <wbauer () tmo ! at>
Date: 2015-06-12 19:15:54
Message-ID: 20150612191554.21202.86353 () mimi ! kde ! org
[Download RAW message or body]
--===============6571107727222910225==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124085/
-----------------------------------------------------------
(Updated June 12, 2015, 7:15 p.m.)
Status
------
This change has been marked as submitted.
Review request for Baloo and Vishesh Handa.
Changes
-------
Submitted with commit ff412d0e8563936c4da5173f014554a288d6f6f9 by Wolfgang \
Bauer to branch master.
Bugs: 332065
http://bugs.kde.org/show_bug.cgi?id=332065
Repository: baloo-widgets
Description
-------
This is the same as http://quickgit.kde.org/?p=baloo-widgets.git&a=commit&h=cda2ccada499b286e5aaa70191847ea376e2f082 \
which seems to have been lost in the KF5 port.
Fixes the display of metadata for files in the home directory when indexing \
is disabled.
Diffs
-----
src/filemetadataprovider.cpp a3dd963
Diff: https://git.reviewboard.kde.org/r/124085/diff/
Testing
-------
Disable file indexing and open your home directory in (KF5 based) dolphin. \
Hover over a file. The metadata is displayed now, it wasn't before.
Thanks,
Wolfgang Bauer
--===============6571107727222910225==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124085/">https://git.reviewboard.kde.org/r/124085/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px \
gray solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated June 12, 2015, 7:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: \
1.5em;">Changes</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit ff412d0e8563936c4da5173f014554a288d6f6f9 \
by Wolfgang Bauer to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=332065">332065</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo-widgets
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This is the same as \
http://quickgit.kde.org/?p=baloo-widgets.git&a=commit&h=cda2ccada499b286e5aaa70191847ea376e2f082 \
which seems to have been lost in the KF5 port.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Fixes the display of metadata for files in the home directory \
when indexing is disabled.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Disable file indexing and \
open your home directory in (KF5 based) dolphin. Hover over a file. The \
metadata is displayed now, it wasn't before.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/filemetadataprovider.cpp <span style="color: \
grey">(a3dd963)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124085/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6571107727222910225==--
[Attachment #3 (text/plain)]
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic