'Re: Review Request 123964: Re-introduce batch committing in baloo_file_extractor'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 123964: Re-introduce batch committing in baloo_file_extractor
From:       "Pinak Ahuja" <pinak.ahuja () gmail ! com>
Date:       2015-06-02 12:05:24
Message-ID: 20150602120524.27809.53561 () mimi ! kde ! org
[Download RAW message or body]

--===============8386135976903677106==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123964/
-----------------------------------------------------------

(Updated June 2, 2015, 12:05 p.m.)

Status
------

This change has been marked as submitted.

Review request for Baloo and Vishesh Handa.

Changes
-------

Submitted with commit 1f043eb1b0745e310ea270a6660fbdb680776b7c by Pinak Ahuja to \
branch master.

Repository: baloo

Description
-------

This patch adds: 
* batch committing to the extractor over stdin. 
* drop QTextStreams.
* We now have a class IOHandler which, takes care of reading/writting for the \
                extractor. This makes testing easier (test for class is included in \
                this patch). 
* Fixes baloo_file_extractor taking loads of memory. We reopen database for every \
transaction (for now).

notes: This patch doesn't take care of extractor getting stuck (will be added in a \
later patch)

Diffs
-----

  src/file/extractor/CMakeLists.txt 529374a 
  src/file/extractor/app.h 856995a 
  src/file/extractor/app.cpp eda4ee0 
  src/file/extractor/autotests/CMakeLists.txt 166d36b 
  src/file/extractor/autotests/iohandlertest.cpp PRE-CREATION 
  src/file/extractor/iohandler.h PRE-CREATION 
  src/file/extractor/iohandler.cpp PRE-CREATION 
  src/file/fileindexingqueue.h 9b3cc18 
  src/file/fileindexingqueue.cpp 818f577 
  src/file/indexingqueue.h 4bea209 

Diff: https://git.reviewboard.kde.org/r/123964/diff/

Testing
-------

IOhandler class is tested with the included test, baloo_file seems to be working \
normally.

Thanks,

Pinak Ahuja

--===============8386135976903677106==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123964/">https://git.reviewboard.kde.org/r/123964/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Pinak Ahuja.</div>

<p style="color: grey;"><i>Updated June 2, 2015, 12:05 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 1f043eb1b0745e310ea270a6660fbdb680776b7c by Pinak \
Ahuja to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
                inherit;white-space: inherit;">This patch adds: 
* batch committing to the extractor over stdin. 
* drop QTextStreams.
* We now have a class IOHandler which, takes care of reading/writting for the \
                extractor. This makes testing easier (test for class is included in \
                this patch). 
* Fixes baloo_file_extractor taking loads of memory. We reopen database for every \
transaction (for now).</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">notes: This patch doesn't take care of \
extractor getting stuck (will be added in a later patch)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">IOhandler class is tested with the included test, \
baloo_file seems to be working normally.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/file/extractor/CMakeLists.txt <span style="color: \
grey">(529374a)</span></li>

 <li>src/file/extractor/app.h <span style="color: grey">(856995a)</span></li>

 <li>src/file/extractor/app.cpp <span style="color: grey">(eda4ee0)</span></li>

 <li>src/file/extractor/autotests/CMakeLists.txt <span style="color: \
grey">(166d36b)</span></li>

 <li>src/file/extractor/autotests/iohandlertest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/file/extractor/iohandler.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/file/extractor/iohandler.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/file/fileindexingqueue.h <span style="color: grey">(9b3cc18)</span></li>

 <li>src/file/fileindexingqueue.cpp <span style="color: grey">(818f577)</span></li>

 <li>src/file/indexingqueue.h <span style="color: grey">(4bea209)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123964/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8386135976903677106==--

[Attachment #3 (text/plain)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 