'Re: Review Request 117436: Doesn't assume that the users home directory is under /home'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 117436: Doesn't assume that the users home directory is under /home
From:       "Vishesh Handa" <me () vhanda ! in>
Date:       2015-02-04 16:26:57
Message-ID: 20150204162657.19249.59757 () probe ! kde ! org
[Download RAW message or body]

--===============2950732002472513380==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117436/#review75426
-----------------------------------------------------------

Ship it!

I seem to have forgotten about this. Sorry.

Do you want me to commit this for you?

- Vishesh Handa

On April 11, 2014, 10:09 p.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117436/
> -----------------------------------------------------------
> 
> (Updated April 11, 2014, 10:09 p.m.)
> 
> 
> Review request for Baloo.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> Part of the KCM code assumes the users home dir is under "/home", which is not \
> always the cause in linux - e.g OpenSUSE with AD Authentication uses a /home/DOMAIN \
> hierarchy. Other systems use /opt. Not to mention windows etc. 
> The code adds a function homeRoot() which returns the parent directory of the uses \
> home directory. 
> 
> Diffs
> -----
> 
> src/file/kcm/folderselectionwidget.cpp bc87a33 
> 
> Diff: https://git.reviewboard.kde.org/r/117436/diff/
> 
> 
> Testing
> -------
> 
> Built, installed. Adding paths to the exclude lists still recognise the home root.
> 
> 
> Thanks,
> 
> Lindsay Mathieson
> 
> 

--===============2950732002472513380==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117436/">https://git.reviewboard.kde.org/r/117436/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
seem to have forgotten about this. Sorry.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Do you want me to \
commit this for you?</p></pre>  <br />

<p>- Vishesh Handa</p>

<br />
<p>On April 11th, 2014, 10:09 p.m. UTC, Lindsay Mathieson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo.</div>
<div>By Lindsay Mathieson.</div>

<p style="color: grey;"><i>Updated April 11, 2014, 10:09 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Part of the KCM code assumes the users home dir is under \
&quot;/home&quot;, which is not always the cause in linux - e.g OpenSUSE with AD \
Authentication uses a /home/DOMAIN hierarchy. Other systems use /opt. Not to mention \
windows etc.

The code adds a function homeRoot() which returns the parent directory of the uses \
home directory.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built, installed. Adding paths to the exclude lists still recognise the \
home root.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/file/kcm/folderselectionwidget.cpp <span style="color: \
grey">(bc87a33)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117436/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2950732002472513380==--

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 