[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 121266: fix build/test by making translation properties testable
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2014-12-12 15:36:20
Message-ID: 20141212153620.4027.94234 () probe ! kde ! org
[Download RAW message or body]
--===============7331951506556864574==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121266/#review71875
-----------------------------------------------------------
src/propertyinfo.cpp
<https://git.reviewboard.kde.org/r/121266/#comment50090>
Could you please add
d->shouldBeIndexed = false
To all of these.
- Vishesh Handa
On Nov. 27, 2014, 9:27 a.m., Harald Sitter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121266/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 9:27 a.m.)
>
>
> Review request for Baloo and Vishesh Handa.
>
>
> Repository: kfilemetadata
>
>
> Description
> -------
>
> propertyinfotest iterates through all properties to make sure beginning
> and end are set correctly and that all properties inbetween have a name
> and description.
>
> this was not the case for new translation properties, making the test fail
>
> due to the nature of this test iterating through everything it would also
> be very useful if the compiler warned about missing propertyinfos which
> is achieved by not using a default case in the respective switch.
>
> also a note comment was added pointing out that an observent developer
> adding a new entry also needs to add it in the fromName function.
>
>
> Diffs
> -----
>
> src/propertyinfo.cpp 751f969eb9b71885323d5456ec7135874657db78
>
> Diff: https://git.reviewboard.kde.org/r/121266/diff/
>
>
> Testing
> -------
>
> make & test
>
>
> Thanks,
>
> Harald Sitter
>
>
--===============7331951506556864574==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121266/">https://git.reviewboard.kde.org/r/121266/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/121266/diff/1/?file=330790#file330790line374" style="color: \
black; font-weight: bold; text-decoration: underline;">src/propertyinfo.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">PropertyInfo::PropertyInfo(Property::Property property)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">374</font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span \
class="o">-></span><span class="n">valueType</span> <span class="o">=</span> <span \
class="n">QVariant</span><span class="o">::</span><span class="n">Int</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Could you please add</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">d->shouldBeIndexed = false</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To all of \
these.</p></pre> </div>
</div>
<br />
<p>- Vishesh Handa</p>
<br />
<p>On November 27th, 2014, 9:27 a.m. UTC, Harald Sitter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated Nov. 27, 2014, 9:27 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">propertyinfotest iterates through all \
properties to make sure beginning and end are set correctly and that all properties inbetween have a name
and description.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
was not the case for new translation properties, making the test fail</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">due to the nature of this \
test iterating through everything it would also be very useful if the compiler warned about missing \
propertyinfos which is achieved by not using a default case in the respective switch.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">also a \
note comment was added pointing out that an observent developer adding a new entry also needs to add it \
in the fromName function.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">make & test</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/propertyinfo.cpp <span style="color: \
grey">(751f969eb9b71885323d5456ec7135874657db78)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121266/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7331951506556864574==--
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic