From kde-devel Fri Dec 05 09:46:01 2014 From: "Christoph Feck" Date: Fri, 05 Dec 2014 09:46:01 +0000 To: kde-devel Subject: Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo Message-Id: <20141205094601.22786.92750 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-devel&m=141777281108545 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6398789970030623616==" --===============6398789970030623616== Content-Type: multipart/alternative; boundary="===============4461886862055652099==" --===============4461886862055652099== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Aug. 12, 2014, 9:33 a.m., Aleix Pol Gonzalez wrote: > > After some discussion with the SDK and Book groups in the sprint, I think we should move this into the kde:kwidgetsaddons repository, in an examples subdirectory. > > Laurent Navet wrote: > do you want me to move this from kdeexamples to kwidgetsaddons ? > > Christoph Feck wrote: > While it indeed makes sense to showcase the features of a framework inside that framework, here I see the problem that the code currently depends on other frameworks. > > So either we showcase multiple frameworks, and have a separate examples repository, or we showcase a single framework, and make sure the examples do not drag in other frameworks. > > Christoph Feck wrote: > Has a decision been made to strip it down to Qt-only dependencies (and KWidgetAddons of course :) for adding it to KWidgetAddons, or ship it in a separate repository, where we can showcase it together with the other useful KF5 features, such as translations, kconfig etc.? > > Dominik Haumann wrote: > As someone who worked on KMessageWidget quite a lot, I'd be in favour of having this demo app in an examples directory, as I think it makes sense to keep the code close together. > > Laurent Navet wrote: > up ! Laurent, the example still uses unrelated frameworks, see my comments above. - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/#review64357 ----------------------------------------------------------- On Aug. 12, 2014, 9:33 a.m., Laurent Navet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114933/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2014, 9:33 a.m.) > > > Review request for KDE Examples, KDE Frameworks and Sune Vuorela. > > > Repository: kdeexamples > > > Description > ------- > > This is part of Google Code-IN Contest. > As I'm no more student, I've waited for the end of the contest to work on it. > > Comments appreciated, > > > Diffs > ----- > > kdeui/kmessagewidgetdemo/CMakeLists.txt 12ef4ac > kdeui/kmessagewidgetdemo/main.cpp d3a5bf0 > kdeui/kmessagewidgetdemo/window.h d3a67c8 > kdeui/kmessagewidgetdemo/window.cpp 9786da6 > > Diff: https://git.reviewboard.kde.org/r/114933/diff/ > > > Testing > ------- > > Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit I've commented the line. > > > Thanks, > > Laurent Navet > > --===============4461886862055652099== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/

On August 12th, 2014, 9:33 a.m. UTC, Aleix Pol Gonzalez wrote:

After some discussion with the SDK and Book groups in the sprint, I think we should move this into the kde:kwidgetsaddons repository, in an examples subdirectory.

On August 12th, 2014, 5:47 p.m. UTC, Laurent Navet wrote:

do you want me to move this from kdeexamples to kwidgetsaddons ?

On August 12th, 2014, 7:56 p.m. UTC, Christoph Feck wrote:

While it indeed makes sense to showcase the features of a framework inside that framework, here I see the problem that the code currently depends on other frameworks.

So either we showcase multiple frameworks, and have a separate examples repository, or we showcase a single framework, and make sure the examples do not drag in other frameworks.

On September 18th, 2014, 9:29 p.m. UTC, Christoph Feck wrote:

Has a decision been made to strip it down to Qt-only dependencies (and KWidgetAddons of course :) for adding it to KWidgetAddons, or ship it in a separate repository, where we can showcase it together with the other useful KF5 features, such as translations, kconfig etc.?

On September 19th, 2014, 10:29 a.m. UTC, Dominik Haumann wrote:

As someone who worked on KMessageWidget quite a lot, I'd be in favour of having this demo app in an examples directory, as I think it makes sense to keep the code close together.

On December 4th, 2014, 10:20 p.m. UTC, Laurent Navet wrote:

up !

Laurent, the example still uses unrelated frameworks, see my comments above.

- Christoph

On August 12th, 2014, 9:33 a.m. UTC, Laurent Navet wrote:

Review request for KDE Examples, KDE Frameworks and Sune Vuorela.

By Laurent Navet.

Updated Aug. 12, 2014, 9:33 a.m.

Repository: kdeexamples

Description

This is part of Google Code-IN Contest. As I'm no more student, I've waited for the end of the contest to work on it.

Comments appreciated,

Testing

Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit I've commented the line.

Diffs

kdeui/kmessagewidgetdemo/CMakeLists.txt (12ef4ac)
kdeui/kmessagewidgetdemo/main.cpp (d3a5bf0)
kdeui/kmessagewidgetdemo/window.h (d3a67c8)
kdeui/kmessagewidgetdemo/window.cpp (9786da6)

--===============4461886862055652099==-- --===============6398789970030623616== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============6398789970030623616==--