'Re: Review Request 120939: [OS X] turn baloo services into proper background "agents" and use IOPOL_'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 120939: [OS X] turn baloo services into proper background "agents" and use IOPOL_
From:       René J.V. Bertin <rjvbertin () gmail ! com>
Date:       2014-11-19 10:50:52
Message-ID: 20141119105052.22978.52271 () probe ! kde ! org
[Download RAW message or body]

--===============5826218706076303689==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120939/
-----------------------------------------------------------

(Updated Nov. 19, 2014, 11:50 a.m.)

Review request for Baloo and KDE Software on Mac OS X.

Repository: baloo

Description
-------

This patch turns baloo_file, akonadi_baloo_indexer and baloo_file_extractor in proper background "agents" \
that do not appear in the Dock, menubar and application switcher.

In addition, use the platform's IOPOL_THROTTLE IO policy when lower priority IO is requested.

Diffs (updated)
-----

  src/file/CMakeLists.txt 49a34dd 
  src/file/extractor/CMakeLists.txt 31efc6a 
  src/file/extractor/main.cpp 4be2c24 
  src/file/priority.cpp 1c4e568 
  src/pim/agent/CMakeLists.txt cd19027 

Diff: https://git.reviewboard.kde.org/r/120939/diff/

Testing
-------

Mac OS X 10.6.8 with kdelibs git/4.14, baloo and kdepim 4.13, akonadi git/1.13 .
Indeed, the patch was prepared with baloo 4.13 but applied cleanly (without fuzziness) to baloo git/4.14 \
.

Thanks,

René J.V. Bertin

--===============5826218706076303689==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120939/">https://git.reviewboard.kde.org/r/120939/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo and KDE Software on Mac OS X.</div>
<div>By René J.V. Bertin.</div>

<p style="color: grey;"><i>Updated Nov. 19, 2014, 11:50 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch turns baloo_file, \
akonadi_baloo_indexer and baloo_file_extractor in proper background "agents" that do not appear in the \
Dock, menubar and application switcher.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">In addition, use the platform's IOPOL_THROTTLE IO policy \
when lower priority IO is requested.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Mac OS X 10.6.8 with kdelibs git/4.14, \
baloo and kdepim 4.13, akonadi git/1.13 . Indeed, the patch was prepared with baloo 4.13 but applied \
cleanly (without fuzziness) to baloo git/4.14 .</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/file/CMakeLists.txt <span style="color: grey">(49a34dd)</span></li>

 <li>src/file/extractor/CMakeLists.txt <span style="color: grey">(31efc6a)</span></li>

 <li>src/file/extractor/main.cpp <span style="color: grey">(4be2c24)</span></li>

 <li>src/file/priority.cpp <span style="color: grey">(1c4e568)</span></li>

 <li>src/pim/agent/CMakeLists.txt <span style="color: grey">(cd19027)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120939/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5826218706076303689==--

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 