[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo
From: "Laurent Navet" <laurent.navet+kde () gmail ! com>
Date: 2014-08-05 7:23:34
Message-ID: 20140805072334.20974.27628 () probe ! kde ! org
[Download RAW message or body]
--===============3121809931120059205==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On août 5, 2014, 8:20 matin, David Faure wrote:
> > Looks good to me. I hope the commit log isn't the same as the reviewboard \
> > description though - it should be about what the patch does, instead.
The commit log is :
-------------------
examples/kdeui/kmessagewidgetdemo : Port to KF5
Change Build system to be KF5 compatible
Remove deprecated KAboutData, KCmdLineArgs
Replace KApplication with QApplication
Repalce KMainWindow with QMainWindow
Replace KAction with QAction
Replace KIcon with QIcon
Replace KLocale with KLocalizedString
Replace KTextEdit with QTextEdit
- Laurent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114933/#review63828
-----------------------------------------------------------
On août 4, 2014, 10:51 après-midi, Laurent Navet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114933/
> -----------------------------------------------------------
>
> (Updated août 4, 2014, 10:51 après-midi)
>
>
> Review request for KDE Examples and Sune Vuorela.
>
>
> Repository: kdeexamples
>
>
> Description
> -------
>
> This is part of Google Code-IN Contest.
> As I'm no more student, I've waited for the end of the contest to work on it.
>
> Comments appreciated,
>
>
> Diffs
> -----
>
> kdeui/kmessagewidgetdemo/CMakeLists.txt 12ef4ac
> kdeui/kmessagewidgetdemo/main.cpp d3a5bf0
> kdeui/kmessagewidgetdemo/window.h d3a67c8
> kdeui/kmessagewidgetdemo/window.cpp 9786da6
>
> Diff: https://git.reviewboard.kde.org/r/114933/diff/
>
>
> Testing
> -------
>
> Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit I've \
> commented the line.
>
> Thanks,
>
> Laurent Navet
>
>
--===============3121809931120059205==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114933/">https://git.reviewboard.kde.org/r/114933/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On août 5th, 2014, 8:20 matin CEST, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Looks good to me. I hope the commit log isn't the same \
as the reviewboard description though - it should be about what the patch does, \
instead.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><h2 style="font-size: \
100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">The commit log is :</h2> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: \
inherit;">examples/kdeui/kmessagewidgetdemo : Port to KF5</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Change Build system to be KF5 compatible</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Remove deprecated KAboutData, KCmdLineArgs<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
Replace KApplication with QApplication<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> Repalce KMainWindow \
with QMainWindow<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> Replace KAction with QAction<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
Replace KIcon with QIcon<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> Replace KLocale with \
KLocalizedString<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> Replace KTextEdit with QTextEdit</p></pre>
<br />
<p>- Laurent</p>
<br />
<p>On août 4th, 2014, 10:51 après-midi CEST, Laurent Navet wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Examples and Sune Vuorela.</div>
<div>By Laurent Navet.</div>
<p style="color: grey;"><i>Updated août 4, 2014, 10:51 après-midi</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeexamples
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is part of Google Code-IN Contest.<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> As I'm no more student, I've waited for the end of the contest to work on \
it.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Comments appreciated,</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Regression on KTextedit::setClickMessage(), as it \
don't exist in QTextEdit I've commented the line.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/kmessagewidgetdemo/CMakeLists.txt <span style="color: \
grey">(12ef4ac)</span></li>
<li>kdeui/kmessagewidgetdemo/main.cpp <span style="color: \
grey">(d3a5bf0)</span></li>
<li>kdeui/kmessagewidgetdemo/window.h <span style="color: \
grey">(d3a67c8)</span></li>
<li>kdeui/kmessagewidgetdemo/window.cpp <span style="color: \
grey">(9786da6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114933/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3121809931120059205==--
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic