'Re: Review Request 118438: Add an option to only build baloo's libraries'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 118438: Add an option to only build baloo's libraries
From:       "Heiko Becker" <heirecka () exherbo ! org>
Date:       2014-07-23 9:29:24
Message-ID: 20140723092924.14616.57287 () probe ! kde ! org
[Download RAW message or body]

--===============1810166440629619399==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118438/
-----------------------------------------------------------

(Updated Juli 23, 2014, 9:29 vorm.)

Review request for Baloo.

Changes
-------

Included the search and pim plugins, move option to the root CMakeLists.txt.

Repository: baloo

Description
-------

The intention behind this review request is to make it easier to turn baloo into a \
framework and make it coinstallable with its KDE4 counterpart in a second review \
request.

That being said I'm not exactly sure this is the way you guys want to go, but I'd be \
willing to update my review request accordingly if you have other plans to make it \
coinstallable.

Diffs (updated)
-----

  CMakeLists.txt abb494ae32ef27e0ca65da341f5d9a0b37f51645 
  src/CMakeLists.txt 810f6dcd97b5f3ff64962709efbfffec7fa9a257 
  src/file/CMakeLists.txt df96fd715866bd159822c5c19c597028fe0e26cd 

Diff: https://git.reviewboard.kde.org/r/118438/diff/

Testing
-------

cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE ..
make
make install

I've also built the frameworks branch of milou against it (needed a few \
modifications).

Thanks,

Heiko Becker

--===============1810166440629619399==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118438/">https://git.reviewboard.kde.org/r/118438/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo.</div>
<div>By Heiko Becker.</div>

<p style="color: grey;"><i>Updated Juli 23, 2014, 9:29 vorm.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Included the search and pim plugins, move option to the root \
CMakeLists.txt.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The intention behind this review request is to make it \
easier to turn baloo into a framework and make it coinstallable with its KDE4 \
counterpart in a second review request.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">That being said I'm not \
exactly sure this is the way you guys want to go, but I'd be willing to update my \
review request accordingly if you have other plans to make it \
coinstallable.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE ..<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> make<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> make install</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I've also built the frameworks branch of milou against \
it (needed a few modifications).</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(abb494ae32ef27e0ca65da341f5d9a0b37f51645)</span></li>

 <li>src/CMakeLists.txt <span style="color: \
grey">(810f6dcd97b5f3ff64962709efbfffec7fa9a257)</span></li>

 <li>src/file/CMakeLists.txt <span style="color: \
grey">(df96fd715866bd159822c5c19c597028fe0e26cd)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118438/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1810166440629619399==--

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 