--===============8841855729513358418== Content-Type: multipart/alternative; boundary="===============5060570348925203650==" --===============5060570348925203650== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118670/ ----------------------------------------------------------- (Updated June 26, 2014, 2:44 p.m.) Status ------ This change has been marked as submitted. Review request for Baloo, Aleix Pol Gonzalez and Vishesh Handa. Repository: kfilemetadata Description ------- Submitting as an official review request, so progress can be properly tracked. As of now, libraries installed from the frameworks branch (based on KF5) collide with the kdelibs4 based libraries from master. Modifying the cmake files allows for parallel installation without too much effort while maintaining the capability to use either mater's or framework's version by finding the appropriate cmake file, thus making life much easier for distributions. Now one option would be to invent some different name to prevent the collisions, but instead we chose a different way: kfilemetadata, just as baloo's libraries, will be a framework at some future point. Then it is likely to use the same notation anyway. So why changing names several times without any real advantages? Therefore the patch changes kfilemetadata's framework branch to match KF5 terminology. The patch was rebased on current framework's head. Additionally, Heiko and I decided to squash our patches as they are trying to achieve the same goal. Diffs ----- CMakeLists.txt 5a9eefa KFileMetaDataConfig.cmake.in b4d1c93 autotests/CMakeLists.txt c657a70 src/CMakeLists.txt 82dbd5c src/extractors/CMakeLists.txt 0099c08 Diff: https://git.reviewboard.kde.org/r/118670/diff/ Testing ------- Thanks, Bernd Steinhauser --===============5060570348925203650== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118670/

This change has been marked as submitted.

Review request for Baloo, Aleix Pol Gonzalez and Vishesh Handa.
By Bernd Steinhauser.

Updated June 26, 2014, 2:44 p.m.

Repository: kfilemetadata

Description 

Submitting as an official review request, so progress can be properly tracked.

As of now, libraries installed from the frameworks branch (based on KF5) collide with the kdelibs4 based libraries from master.
Modifying the cmake files allows for parallel installation without too much effort while maintaining the capability to use either mater's or framework's version by finding the appropriate cmake file, thus making life much easier for distributions.

Now one option would be to invent some different name to prevent the collisions, but instead we chose a different way:
kfilemetadata, just as baloo's libraries, will be a framework at some future point. Then it is likely to use the same notation anyway. So why changing names several times without any real advantages?
Therefore the patch changes kfilemetadata's framework branch to match KF5 terminology.

The patch was rebased on current framework's head. Additionally, Heiko and I decided to squash our patches as they are trying to achieve the same goal.

Diffs

  • CMakeLists.txt (5a9eefa)
  • KFileMetaDataConfig.cmake.in (b4d1c93)
  • autotests/CMakeLists.txt (c657a70)
  • src/CMakeLists.txt (82dbd5c)
  • src/extractors/CMakeLists.txt (0099c08)

View Diff
--===============5060570348925203650==-- --===============8841855729513358418== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============8841855729513358418==--