'Re: Review Request 118752: Fix Baloo to work against frameworkified KFileMetaData.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 118752: Fix Baloo to work against frameworkified KFileMetaData.
From:       "Matthew Dawson" <matthew () mjdsystems ! ca>
Date:       2014-06-26 14:45:05
Message-ID: 20140626144505.26151.81780 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118752/
-----------------------------------------------------------

(Updated June 26, 2014, 2:45 p.m.)

Status
------

This change has been marked as submitted.

Review request for Baloo.

Repository: baloo

Description
-------

Fix Baloo to work against frameworkified KFileMetaData.

Change Baloo to find KFileMetaData as a proper framework, and change the
necessary include statements.

Diffs
-----

  src/tools/balooshow/main.cpp db0acb019c9bda696775150ccc4f6007fec7be82 
  src/file/search/filesearchstore.cpp 0b1a6201ed7ae12f776daf2392313406d0168de3 
  src/file/search/CMakeLists.txt 5549943aaf98026a698b4a4ae6bba4df01699012 
  src/file/lib/file_p.h a4fcf44325a360149fa646e8b8adb15c68a6b20e 
  src/file/lib/file.h 89c03e2c3ddcc7215ec8451caeeb6323b8eeed9b 
  src/file/lib/autotests/filefetchjobtest.cpp f9c49ff30ee119950603f1b9628c14fffe0bd5dd 
  src/file/extractor/result.cpp b2d5615ce3645d6e0ff435b3771539e1aeea5380 
  src/file/extractor/result.h 3dbde3d333076543f141859b074da47d1ed593c2 
  src/file/extractor/app.cpp 00c250e5796c58b0fb1a7b7f8ba7849df557f56e 
  src/file/extractor/app.h 9e674d369fb25538ed971dce9026fe53d697db3e 
  src/file/basicindexingjob.cpp b53cd79ccded7ce901cfd80c1eea119c6f6ab121 
  src/file/basicindexingjob.h f72680c499de5f6d48a1b2bdedceb1877101e3b2 
  CMakeLists.txt 7a07aa465601d4d196e9fa9158c05d1573d0f90d 

Diff: https://git.reviewboard.kde.org/r/118752/diff/

Testing
-------

Compiles and tests fine.

Thanks,

Matthew Dawson

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118752/">https://git.reviewboard.kde.org/r/118752/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Baloo.</div>
<div>By Matthew Dawson.</div>

<p style="color: grey;"><i>Updated June 26, 2014, 2:45 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix Baloo to work against frameworkified KFileMetaData.

Change Baloo to find KFileMetaData as a proper framework, and change the
necessary include statements.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles and tests fine.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/tools/balooshow/main.cpp <span style="color: \
grey">(db0acb019c9bda696775150ccc4f6007fec7be82)</span></li>

 <li>src/file/search/filesearchstore.cpp <span style="color: \
grey">(0b1a6201ed7ae12f776daf2392313406d0168de3)</span></li>

 <li>src/file/search/CMakeLists.txt <span style="color: \
grey">(5549943aaf98026a698b4a4ae6bba4df01699012)</span></li>

 <li>src/file/lib/file_p.h <span style="color: \
grey">(a4fcf44325a360149fa646e8b8adb15c68a6b20e)</span></li>

 <li>src/file/lib/file.h <span style="color: \
grey">(89c03e2c3ddcc7215ec8451caeeb6323b8eeed9b)</span></li>

 <li>src/file/lib/autotests/filefetchjobtest.cpp <span style="color: \
grey">(f9c49ff30ee119950603f1b9628c14fffe0bd5dd)</span></li>

 <li>src/file/extractor/result.cpp <span style="color: \
grey">(b2d5615ce3645d6e0ff435b3771539e1aeea5380)</span></li>

 <li>src/file/extractor/result.h <span style="color: \
grey">(3dbde3d333076543f141859b074da47d1ed593c2)</span></li>

 <li>src/file/extractor/app.cpp <span style="color: \
grey">(00c250e5796c58b0fb1a7b7f8ba7849df557f56e)</span></li>

 <li>src/file/extractor/app.h <span style="color: \
grey">(9e674d369fb25538ed971dce9026fe53d697db3e)</span></li>

 <li>src/file/basicindexingjob.cpp <span style="color: \
grey">(b53cd79ccded7ce901cfd80c1eea119c6f6ab121)</span></li>

 <li>src/file/basicindexingjob.h <span style="color: \
grey">(f72680c499de5f6d48a1b2bdedceb1877101e3b2)</span></li>

 <li>CMakeLists.txt <span style="color: \
grey">(7a07aa465601d4d196e9fa9158c05d1573d0f90d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118752/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 