[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 118670: Change kfilemetadata's naming scheme to match KF5 libraries
From: "Commit Hook" <null () kde ! org>
Date: 2014-06-26 14:44:54
Message-ID: 20140626144454.25128.87691 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118670/#review61032
-----------------------------------------------------------
This review has been submitted with commit a47292be3ca6fb970438bef8bc8957349dded9b4 \
by Vishesh Handa on behalf of Bernd Steinhauser to branch frameworks.
- Commit Hook
On June 12, 2014, 5:47 p.m., Bernd Steinhauser wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118670/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 5:47 p.m.)
>
>
> Review request for Baloo, Aleix Pol Gonzalez and Vishesh Handa.
>
>
> Repository: kfilemetadata
>
>
> Description
> -------
>
> Submitting as an official review request, so progress can be properly tracked.
>
> As of now, libraries installed from the frameworks branch (based on KF5) collide \
> with the kdelibs4 based libraries from master. Modifying the cmake files allows for \
> parallel installation without too much effort while maintaining the capability to \
> use either mater's or framework's version by finding the appropriate cmake file, \
> thus making life much easier for distributions.
> Now one option would be to invent some different name to prevent the collisions, \
> but instead we chose a different way: kfilemetadata, just as baloo's libraries, \
> will be a framework at some future point. Then it is likely to use the same \
> notation anyway. So why changing names several times without any real advantages? \
> Therefore the patch changes kfilemetadata's framework branch to match KF5 \
> terminology.
> The patch was rebased on current framework's head. Additionally, Heiko and I \
> decided to squash our patches as they are trying to achieve the same goal.
>
> Diffs
> -----
>
> CMakeLists.txt 5a9eefa
> KFileMetaDataConfig.cmake.in b4d1c93
> autotests/CMakeLists.txt c657a70
> src/CMakeLists.txt 82dbd5c
> src/extractors/CMakeLists.txt 0099c08
>
> Diff: https://git.reviewboard.kde.org/r/118670/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bernd Steinhauser
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118670/">https://git.reviewboard.kde.org/r/118670/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit a47292be3ca6fb970438bef8bc8957349dded9b4 by Vishesh Handa on \
behalf of Bernd Steinhauser to branch frameworks.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On June 12th, 2014, 5:47 p.m. UTC, Bernd Steinhauser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo, Aleix Pol Gonzalez and Vishesh Handa.</div>
<div>By Bernd Steinhauser.</div>
<p style="color: grey;"><i>Updated June 12, 2014, 5:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitting as an official review request, so progress can be properly \
tracked.
As of now, libraries installed from the frameworks branch (based on KF5) collide with \
the kdelibs4 based libraries from master. Modifying the cmake files allows for \
parallel installation without too much effort while maintaining the capability to use \
either mater's or framework's version by finding the appropriate cmake file, \
thus making life much easier for distributions.
Now one option would be to invent some different name to prevent the collisions, but \
instead we chose a different way: kfilemetadata, just as baloo's libraries, will \
be a framework at some future point. Then it is likely to use the same notation \
anyway. So why changing names several times without any real advantages? Therefore \
the patch changes kfilemetadata's framework branch to match KF5 terminology.
The patch was rebased on current framework's head. Additionally, Heiko and I \
decided to squash our patches as they are trying to achieve the same goal.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(5a9eefa)</span></li>
<li>KFileMetaDataConfig.cmake.in <span style="color: grey">(b4d1c93)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(c657a70)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(82dbd5c)</span></li>
<li>src/extractors/CMakeLists.txt <span style="color: grey">(0099c08)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118670/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic