[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 118752: Fix Baloo to work against frameworkified KFileMetaData.
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2014-06-25 9:58:48
Message-ID: 20140625095848.7396.13633 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 17, 2014, 1:43 p.m., Vishesh Handa wrote:
> > src/file/basicindexingjob.cpp, line 32
> > <https://git.reviewboard.kde.org/r/118752/diff/2/?file=281845#file281845line32>
> >
> > I'm a little surprised this works. Could you please add the explicit \
> > <KFileMetaData/TypeInfo> instead. This way it is obvious where it comes from.
> > In this case I agree with the whole Python mantra of "Explicit is better than \
> > implicit"
>
> Matthew Dawson wrote:
> I would have actually preferred to use that form for the includes, however it \
> appears that the build system does not properly setup the include directories to \
> allow that form. When compiling most of Baloo, /usr/include/KF5 is in the include \
> path (seen by checking the actual compilation command). However, at least one unit \
> test and one executable do not.
> In both cases, /usr/include/KF5/KFileMetaData is in the include path (again \
> verified by inspecting the compilation command). I don't know why the include path \
> changes, as of right now switching the includes will break.
> I think this patch as is should go in, as otherwise Baloo won't compile at all. I \
> can then start chasing down the problems with doing this change, and fix it later.
> Matthew Dawson wrote:
> ping
>
> Does this still need to be fixed for this patch to be committed? I haven't had \
> time to chase down why the explicit form doesn't work yet.
> Also, can I commit https://git.reviewboard.kde.org/r/118670/ (with proper \
> attribution) as well, since the author doesn't have commit access? Otherwise this \
> patch can't be committed at all :)
Hey.
Yes, this can go in and you can work on fixing the rest. Would it be all right if I \
committed this patch and the KFileMetadata one? I don't want to push one and not the \
other since stuff will break.
Or if you really want you can do it.
- Vishesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118752/#review60251
-----------------------------------------------------------
On June 16, 2014, 10:05 p.m., Matthew Dawson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118752/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 10:05 p.m.)
>
>
> Review request for Baloo.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Fix Baloo to work against frameworkified KFileMetaData.
>
> Change Baloo to find KFileMetaData as a proper framework, and change the
> necessary include statements.
>
>
> Diffs
> -----
>
> src/tools/balooshow/main.cpp db0acb019c9bda696775150ccc4f6007fec7be82
> src/file/search/filesearchstore.cpp 0b1a6201ed7ae12f776daf2392313406d0168de3
> src/file/search/CMakeLists.txt 5549943aaf98026a698b4a4ae6bba4df01699012
> src/file/lib/file_p.h a4fcf44325a360149fa646e8b8adb15c68a6b20e
> src/file/lib/file.h 89c03e2c3ddcc7215ec8451caeeb6323b8eeed9b
> src/file/lib/autotests/filefetchjobtest.cpp \
> f9c49ff30ee119950603f1b9628c14fffe0bd5dd src/file/extractor/result.cpp \
> b2d5615ce3645d6e0ff435b3771539e1aeea5380 src/file/extractor/result.h \
> 3dbde3d333076543f141859b074da47d1ed593c2 src/file/extractor/app.cpp \
> 00c250e5796c58b0fb1a7b7f8ba7849df557f56e src/file/extractor/app.h \
> 9e674d369fb25538ed971dce9026fe53d697db3e src/file/basicindexingjob.cpp \
> b53cd79ccded7ce901cfd80c1eea119c6f6ab121 src/file/basicindexingjob.h \
> f72680c499de5f6d48a1b2bdedceb1877101e3b2 CMakeLists.txt \
> 7a07aa465601d4d196e9fa9158c05d1573d0f90d
> Diff: https://git.reviewboard.kde.org/r/118752/diff/
>
>
> Testing
> -------
>
> Compiles and tests fine.
>
>
> Thanks,
>
> Matthew Dawson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118752/">https://git.reviewboard.kde.org/r/118752/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 17th, 2014, 1:43 p.m. UTC, <b>Vishesh \
Handa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118752/diff/2/?file=281845#file281845line32" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/file/basicindexingjob.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">32</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include \
<<span class="hl">kfilemetadata/t</span>ype<span class="hl">i</span>nfo<span \
class="hl">.h</span>></span></pre></td> <th bgcolor="#e9eaa8" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">32</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="cp">#include <<span \
class="hl">T</span>ype<span class="hl">I</span>nfo></span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm a little \
surprised this works. Could you please add the explicit \
<KFileMetaData/TypeInfo> instead. This way it is obvious where it comes from.
In this case I agree with the whole Python mantra of "Explicit is better than \
implicit"</pre> </blockquote>
<p>On June 17th, 2014, 3:06 p.m. UTC, <b>Matthew Dawson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would have actually \
preferred to use that form for the includes, however it appears that the build system \
does not properly setup the include directories to allow that form. When compiling \
most of Baloo, /usr/include/KF5 is in the include path (seen by checking the actual \
compilation command). However, at least one unit test and one executable do not.
In both cases, /usr/include/KF5/KFileMetaData is in the include path (again verified \
by inspecting the compilation command). I don't know why the include path \
changes, as of right now switching the includes will break.
I think this patch as is should go in, as otherwise Baloo won't compile at all. \
I can then start chasing down the problems with doing this change, and fix it \
later.</pre> </blockquote>
<p>On June 25th, 2014, 12:22 a.m. UTC, <b>Matthew Dawson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ping
Does this still need to be fixed for this patch to be committed? I haven't had \
time to chase down why the explicit form doesn't work yet.
Also, can I commit https://git.reviewboard.kde.org/r/118670/ (with proper \
attribution) as well, since the author doesn't have commit access? Otherwise \
this patch can't be committed at all :)</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hey.
Yes, this can go in and you can work on fixing the rest. Would it be all right if I \
committed this patch and the KFileMetadata one? I don't want to push one and not \
the other since stuff will break.
Or if you really want you can do it.</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On June 16th, 2014, 10:05 p.m. UTC, Matthew Dawson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo.</div>
<div>By Matthew Dawson.</div>
<p style="color: grey;"><i>Updated June 16, 2014, 10:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix Baloo to work against frameworkified KFileMetaData.
Change Baloo to find KFileMetaData as a proper framework, and change the
necessary include statements.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles and tests fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/tools/balooshow/main.cpp <span style="color: \
grey">(db0acb019c9bda696775150ccc4f6007fec7be82)</span></li>
<li>src/file/search/filesearchstore.cpp <span style="color: \
grey">(0b1a6201ed7ae12f776daf2392313406d0168de3)</span></li>
<li>src/file/search/CMakeLists.txt <span style="color: \
grey">(5549943aaf98026a698b4a4ae6bba4df01699012)</span></li>
<li>src/file/lib/file_p.h <span style="color: \
grey">(a4fcf44325a360149fa646e8b8adb15c68a6b20e)</span></li>
<li>src/file/lib/file.h <span style="color: \
grey">(89c03e2c3ddcc7215ec8451caeeb6323b8eeed9b)</span></li>
<li>src/file/lib/autotests/filefetchjobtest.cpp <span style="color: \
grey">(f9c49ff30ee119950603f1b9628c14fffe0bd5dd)</span></li>
<li>src/file/extractor/result.cpp <span style="color: \
grey">(b2d5615ce3645d6e0ff435b3771539e1aeea5380)</span></li>
<li>src/file/extractor/result.h <span style="color: \
grey">(3dbde3d333076543f141859b074da47d1ed593c2)</span></li>
<li>src/file/extractor/app.cpp <span style="color: \
grey">(00c250e5796c58b0fb1a7b7f8ba7849df557f56e)</span></li>
<li>src/file/extractor/app.h <span style="color: \
grey">(9e674d369fb25538ed971dce9026fe53d697db3e)</span></li>
<li>src/file/basicindexingjob.cpp <span style="color: \
grey">(b53cd79ccded7ce901cfd80c1eea119c6f6ab121)</span></li>
<li>src/file/basicindexingjob.h <span style="color: \
grey">(f72680c499de5f6d48a1b2bdedceb1877101e3b2)</span></li>
<li>CMakeLists.txt <span style="color: \
grey">(7a07aa465601d4d196e9fa9158c05d1573d0f90d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118752/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic