[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 118670: Change kfilemetadata's naming scheme to match KF5 libraries
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2014-06-12 14:30:21
Message-ID: 20140612143021.3231.54586 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118670/#review59884
-----------------------------------------------------------
Looks good to me otherwise. Let Aleix comment on this.
src/extractors/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118670/#comment41711>
Could you please change most of these to KF5::FileMetaData?
It would look way more consistent that way.
- Vishesh Handa
On June 11, 2014, 5:42 p.m., Bernd Steinhauser wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118670/
> -----------------------------------------------------------
>
> (Updated June 11, 2014, 5:42 p.m.)
>
>
> Review request for Baloo and Vishesh Handa.
>
>
> Repository: kfilemetadata
>
>
> Description
> -------
>
> Submitting as an official review request, so progress can be properly tracked.
>
> As of now, libraries installed from the frameworks branch (based on KF5) collide \
> with the kdelibs4 based libraries from master. Modifying the cmake files allows for \
> parallel installation without too much effort while maintaining the capability to \
> use either mater's or framework's version by finding the appropriate cmake file, \
> thus making life much easier for distributions.
> Now one option would be to invent some different name to prevent the collisions, \
> but instead we chose a different way: kfilemetadata, just as baloo's libraries, \
> will be a framework at some future point. Then it is likely to use the same \
> notation anyway. So why changing names several times without any real advantages? \
> Therefore the patch changes kfilemetadata's framework branch to match KF5 \
> terminology.
> The patch was rebased on current framework's head. Additionally, Heiko and I \
> decided to squash our patches as they are trying to achieve the same goal.
>
> Diffs
> -----
>
> CMakeLists.txt 5a9eefa
> KFileMetaDataConfig.cmake.in b4d1c93
> autotests/CMakeLists.txt c657a70
> src/CMakeLists.txt 82dbd5c
> src/extractors/CMakeLists.txt 0099c08
>
> Diff: https://git.reviewboard.kde.org/r/118670/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bernd Steinhauser
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118670/">https://git.reviewboard.kde.org/r/118670/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me \
otherwise. Let Aleix comment on this.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118670/diff/1/?file=280295#file280295line197" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/extractors/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">197</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s"><span \
class="hl">kf</span>ile<span class="hl">m</span>etadata</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">197</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s"><span class="hl">KF5KF</span>ile<span \
class="hl">M</span>etadata</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you \
please change most of these to KF5::FileMetaData?
It would look way more consistent that way.</pre>
</div>
<br />
<p>- Vishesh Handa</p>
<br />
<p>On June 11th, 2014, 5:42 p.m. UTC, Bernd Steinhauser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Bernd Steinhauser.</div>
<p style="color: grey;"><i>Updated June 11, 2014, 5:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitting as an official review request, so progress can be properly \
tracked.
As of now, libraries installed from the frameworks branch (based on KF5) collide with \
the kdelibs4 based libraries from master. Modifying the cmake files allows for \
parallel installation without too much effort while maintaining the capability to use \
either mater's or framework's version by finding the appropriate cmake file, \
thus making life much easier for distributions.
Now one option would be to invent some different name to prevent the collisions, but \
instead we chose a different way: kfilemetadata, just as baloo's libraries, will \
be a framework at some future point. Then it is likely to use the same notation \
anyway. So why changing names several times without any real advantages? Therefore \
the patch changes kfilemetadata's framework branch to match KF5 terminology.
The patch was rebased on current framework's head. Additionally, Heiko and I \
decided to squash our patches as they are trying to achieve the same goal.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(5a9eefa)</span></li>
<li>KFileMetaDataConfig.cmake.in <span style="color: grey">(b4d1c93)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(c657a70)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(82dbd5c)</span></li>
<li>src/extractors/CMakeLists.txt <span style="color: grey">(0099c08)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118670/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic