From kde-devel Tue Jun 10 12:29:53 2014 From: "Michael Palimaka" Date: Tue, 10 Jun 2014 12:29:53 +0000 To: kde-devel Subject: Re: Review Request 118628: Make tests behave more like frameworks. Message-Id: <20140610122953.17951.58569 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-devel&m=140240343323560 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0359859885225269914==" --===============0359859885225269914== Content-Type: multipart/alternative; boundary="===============3538464962133800937==" --===============3538464962133800937== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118628/ ----------------------------------------------------------- (Updated June 10, 2014, 12:29 p.m.) Status ------ This change has been marked as submitted. Review request for Baloo. Repository: kfilemetadata Description ------- Make tests behave more like frameworks, by respecting the BUILD_TESTING option from ECM and only locating QtTest when necessary. The default behaviour remains the same. Diffs ----- CMakeLists.txt aa2b0864ca8b2126ffcabf5cbad28b06dbb682b2 autotests/CMakeLists.txt 95c3e302122d3b9a01f70e74812c2b374ac46023 Diff: https://git.reviewboard.kde.org/r/118628/diff/ Testing ------- Tests pass/are ignored with the appropriate build option. Thanks, Michael Palimaka --===============3538464962133800937== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118628/

This change has been marked as submitted.

Review request for Baloo.
By Michael Palimaka.

Updated June 10, 2014, 12:29 p.m.

Repository: kfilemetadata

Description 

Make tests behave more like frameworks, by respecting the BUILD_TESTING option from ECM and only locating QtTest when necessary. The default behaviour remains the same.

Testing 

Tests pass/are ignored with the appropriate build option.

Diffs

  • CMakeLists.txt (aa2b0864ca8b2126ffcabf5cbad28b06dbb682b2)
  • autotests/CMakeLists.txt (95c3e302122d3b9a01f70e74812c2b374ac46023)

View Diff
--===============3538464962133800937==-- --===============0359859885225269914== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============0359859885225269914==--