[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 118628: Make tests behave more like frameworks.
From: "Michael Palimaka" <kensington () gentoo ! org>
Date: 2014-06-10 12:18:18
Message-ID: 20140610121818.17951.98185 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 10, 2014, 12:16 p.m., Bhushan Shah wrote:
> > CMakeLists.txt, line 64
> > <https://git.reviewboard.kde.org/r/118628/diff/1/?file=279885#file279885line64>
> >
> > hmm what about using ecm_add_test?
That's already used in autotests/CMakeLists.txt
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118628/#review59672
-----------------------------------------------------------
On June 9, 2014, 5:11 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118628/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 5:11 p.m.)
>
>
> Review request for Baloo.
>
>
> Repository: kfilemetadata
>
>
> Description
> -------
>
> Make tests behave more like frameworks, by respecting the BUILD_TESTING option from \
> ECM and only locating QtTest when necessary. The default behaviour remains the \
> same.
>
> Diffs
> -----
>
> CMakeLists.txt aa2b0864ca8b2126ffcabf5cbad28b06dbb682b2
> autotests/CMakeLists.txt 95c3e302122d3b9a01f70e74812c2b374ac46023
>
> Diff: https://git.reviewboard.kde.org/r/118628/diff/
>
>
> Testing
> -------
>
> Tests pass/are ignored with the appropriate build option.
>
>
> Thanks,
>
> Michael Palimaka
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118628/">https://git.reviewboard.kde.org/r/118628/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 10th, 2014, 12:16 p.m. UTC, <b>Bhushan \
Shah</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118628/diff/1/?file=279885#file279885line64" \
style="color: black; font-weight: bold; text-decoration: \
underline;">CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">64</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">if</span> <span class="p">(</span><span \
class="s">BUILD_TESTING</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">hmm what about using \
ecm_add_test?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's \
already used in autotests/CMakeLists.txt</pre> <br />
<p>- Michael</p>
<br />
<p>On June 9th, 2014, 5:11 p.m. UTC, Michael Palimaka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo.</div>
<div>By Michael Palimaka.</div>
<p style="color: grey;"><i>Updated June 9, 2014, 5:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make tests behave more like frameworks, by respecting the BUILD_TESTING \
option from ECM and only locating QtTest when necessary. The default behaviour \
remains the same.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tests pass/are ignored with the appropriate build option.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(aa2b0864ca8b2126ffcabf5cbad28b06dbb682b2)</span></li>
<li>autotests/CMakeLists.txt <span style="color: \
grey">(95c3e302122d3b9a01f70e74812c2b374ac46023)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118628/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic