'Re: Review Request 118628: Make tests behave more like frameworks.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 118628: Make tests behave more like frameworks.
From:       "Vishesh Handa" <me () vhanda ! in>
Date:       2014-06-10 12:11:38
Message-ID: 20140610121138.24416.22797 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118628/#review59670
-----------------------------------------------------------

Ship it!

Looks good!

- Vishesh Handa

On June 9, 2014, 5:11 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118628/
> -----------------------------------------------------------
> 
> (Updated June 9, 2014, 5:11 p.m.)
> 
> 
> Review request for Baloo.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> -------
> 
> Make tests behave more like frameworks, by respecting the BUILD_TESTING option from \
> ECM and only locating QtTest when necessary. The default behaviour remains the \
> same. 
> 
> Diffs
> -----
> 
> CMakeLists.txt aa2b0864ca8b2126ffcabf5cbad28b06dbb682b2 
> autotests/CMakeLists.txt 95c3e302122d3b9a01f70e74812c2b374ac46023 
> 
> Diff: https://git.reviewboard.kde.org/r/118628/diff/
> 
> 
> Testing
> -------
> 
> Tests pass/are ignored with the appropriate build option.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118628/">https://git.reviewboard.kde.org/r/118628/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good!</pre>  <br \
/>

<p>- Vishesh Handa</p>

<br />
<p>On June 9th, 2014, 5:11 p.m. UTC, Michael Palimaka wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Baloo.</div>
<div>By Michael Palimaka.</div>

<p style="color: grey;"><i>Updated June 9, 2014, 5:11 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make tests behave more like frameworks, by respecting the BUILD_TESTING \
option from ECM and only locating QtTest when necessary. The default behaviour \
remains the same.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tests pass/are ignored with the appropriate build option.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(aa2b0864ca8b2126ffcabf5cbad28b06dbb682b2)</span></li>

 <li>autotests/CMakeLists.txt <span style="color: \
grey">(95c3e302122d3b9a01f70e74812c2b374ac46023)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118628/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 