This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118438/

Review request for Baloo.
By Heiko Becker.
Repository: baloo

Description

The intention behind this review request is to make it easier to turn baloo into a framework and make it coinstallable with its KDE4 counterpart in a second review request.

That being said I'm not exactly sure this is the way you guys want to go, but I'd be willing to update my review request accordingly if you have other plans to make it coinstallable.

Testing

cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE ..
make
make install

I've also built the frameworks branch of milou against it (needed a few modifications).

Diffs

  • src/CMakeLists.txt (de044025012ebcccb8a9c7293edfe045cc9b7856)
  • src/file/CMakeLists.txt (4f9fb9dd6b0e680a5f70cfaeb3986000cb192acd)

View Diff