From kde-devel Sat May 31 11:54:17 2014 From: "Heiko Becker" Date: Sat, 31 May 2014 11:54:17 +0000 To: kde-devel Subject: Review Request 118438: Add an option to only build baloo's libraries Message-Id: <20140531115417.7243.61092 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-devel&m=140153730928804 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5506555100838488021==" --===============5506555100838488021== Content-Type: multipart/alternative; boundary="===============1388909658331355348==" --===============1388909658331355348== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118438/ ----------------------------------------------------------- Review request for Baloo. Repository: baloo Description ------- The intention behind this review request is to make it easier to turn baloo into a framework and make it coinstallable with its KDE4 counterpart in a second review request. That being said I'm not exactly sure this is the way you guys want to go, but I'd be willing to update my review request accordingly if you have other plans to make it coinstallable. Diffs ----- src/CMakeLists.txt de044025012ebcccb8a9c7293edfe045cc9b7856 src/file/CMakeLists.txt 4f9fb9dd6b0e680a5f70cfaeb3986000cb192acd Diff: https://git.reviewboard.kde.org/r/118438/diff/ Testing ------- cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE .. make make install I've also built the frameworks branch of milou against it (needed a few modifications). Thanks, Heiko Becker --===============1388909658331355348== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118438/

Review request for Baloo.

By Heiko Becker.

Repository: baloo

Description

The intention behind this review request is to make it easier to turn baloo into a framework and make it coinstallable with its KDE4 counterpart in a second review request.

That being said I'm not exactly sure this is the way you guys want to go, but I'd be willing to update my review request accordingly if you have other plans to make it coinstallable.

Testing

cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE ..
make
make install

I've also built the frameworks branch of milou against it (needed a few modifications).

Diffs

src/CMakeLists.txt (de044025012ebcccb8a9c7293edfe045cc9b7856)
src/file/CMakeLists.txt (4f9fb9dd6b0e680a5f70cfaeb3986000cb192acd)

View Diff

--===============1388909658331355348==-- --===============5506555100838488021== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============5506555100838488021==--