'Review Request 118231: Scheduler for the akonadi indexer.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Review Request 118231: Scheduler for the akonadi indexer.
From:       "Christian Mollekopf" <chrigi_1 () fastmail ! fm>
Date:       2014-05-20 22:22:28
Message-ID: 20140520222228.16632.43727 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118231/
-----------------------------------------------------------

Review request for Baloo and Vishesh Handa.

Repository: baloo

Description
-------

A scheduler for baloo: 
* delays the indexing until no new item has been added for at least 5 seconds to \
                avoid indexing during a collection sync.
* remembers if it failed to index something and triggers recovery path on next start.
* supports manual triggering of recovery path if required.

Diffs
-----

  src/pim/agent/CMakeLists.txt e917915a3414738595caea5497859ef4810ec44c 
  src/pim/agent/agent.h 1dbf0fc0a16d0615dbfa4878706359bb687facd0 
  src/pim/agent/agent.cpp 8904d49d3579b58b634d2570fbcc8007e5ee41ed 
  src/pim/agent/collectionindexingjob.h PRE-CREATION 
  src/pim/agent/collectionindexingjob.cpp PRE-CREATION 
  src/pim/agent/index.h PRE-CREATION 
  src/pim/agent/index.cpp PRE-CREATION 
  src/pim/agent/scheduler.h PRE-CREATION 
  src/pim/agent/scheduler.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/118231/diff/

Testing
-------

I'm running it for a while, and it reduced the stress that baloo imposed on my system \
and all my mails are indexed since I'm using it (wasn't the case before).

Thanks,

Christian Mollekopf

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118231/">https://git.reviewboard.kde.org/r/118231/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Christian Mollekopf.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">A scheduler for baloo: 
* delays the indexing until no new item has been added for at least 5 seconds to \
                avoid indexing during a collection sync.
* remembers if it failed to index something and triggers recovery path on next start.
* supports manual triggering of recovery path if required.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;m running it for a while, and it reduced the stress that baloo \
imposed on my system and all my mails are indexed since I&#39;m using it (wasn&#39;t \
the case before).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/pim/agent/CMakeLists.txt <span style="color: \
grey">(e917915a3414738595caea5497859ef4810ec44c)</span></li>

 <li>src/pim/agent/agent.h <span style="color: \
grey">(1dbf0fc0a16d0615dbfa4878706359bb687facd0)</span></li>

 <li>src/pim/agent/agent.cpp <span style="color: \
grey">(8904d49d3579b58b634d2570fbcc8007e5ee41ed)</span></li>

 <li>src/pim/agent/collectionindexingjob.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/pim/agent/collectionindexingjob.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/pim/agent/index.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/pim/agent/index.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/pim/agent/scheduler.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/pim/agent/scheduler.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118231/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 