--===============0064833366088830897== Content-Type: multipart/alternative; boundary="===============2209133191269622874==" --===============2209133191269622874== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/ ----------------------------------------------------------- (Updated May 5, 2014, 4:35 p.m.) Status ------ This change has been marked as submitted. Review request for Baloo and Milian Wolff. Repository: kfilemetadata Description ------- Add an append(QByteArray) method to the ExtractionResult This way plugins can choose to return the data in utf8 or as a QString, and the clients can either just let the standard QString::fromUtf8 function do its magic, or implement some special handling if they wish. This speeds up the PlainTextExtractor quite a bit (60msec vs 8.3msec) Unfortunately, this meant discarding the extraction of WordCount from the Plain Text extractor. Though considering the speed difference, I think it is worth it. Diffs ----- autotests/indexerextractortests.cpp 6b7c605 src/extractors/plaintextextractor.cpp 5a38857 Diff: https://git.reviewboard.kde.org/r/117996/diff/ Testing ------- Thanks, Vishesh Handa --===============2209133191269622874== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/

This change has been marked as submitted.

Review request for Baloo and Milian Wolff.

By Vishesh Handa.

Updated May 5, 2014, 4:35 p.m.

Repository: kfilemetadata

Description

    Add an append(QByteArray) method to the ExtractionResult

    This way plugins can choose to return the data in utf8 or as a QString,
    and the clients can either just let the standard QString::fromUtf8
    function do its magic, or implement some special handling if they wish.

    This speeds up the PlainTextExtractor quite a bit (60msec vs 8.3msec)

    Unfortunately, this meant discarding the extraction of WordCount from
    the Plain Text extractor. Though considering the speed difference, I
    think it is worth it.

Diffs

autotests/indexerextractortests.cpp (6b7c605)
src/extractors/plaintextextractor.cpp (5a38857)

View Diff

--===============2209133191269622874==-- --===============0064833366088830897== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============0064833366088830897==--