[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult
From: "Milian Wolff" <mail () milianw ! de>
Date: 2014-05-05 15:19:57
Message-ID: 20140505151957.19582.32832 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117996/#review57322
-----------------------------------------------------------
src/extractionresult.cpp
<https://git.reviewboard.kde.org/r/117996/#comment39922>
OK but then I don't get why you can compile this. You provide a definition of the \
pure-virtual declaration here, no? That's not going to compile, is it?
Generally, I'd say don't make it pure-virtual as you can provide a meaningful \
default-implementation here... Only for performance reasons would one want to \
reimplement it after all.
- Milian Wolff
On May 5, 2014, 2:01 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117996/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 2:01 p.m.)
>
>
> Review request for Baloo and Milian Wolff.
>
>
> Repository: kfilemetadata
>
>
> Description
> -------
>
> Add an append(QByteArray) method to the ExtractionResult
>
> This way plugins can choose to return the data in utf8 or as a QString,
> and the clients can either just let the standard QString::fromUtf8
> function do its magic, or implement some special handling if they wish.
>
> This speeds up the PlainTextExtractor quite a bit (60msec vs 8.3msec)
>
> Unfortunately, this meant discarding the extraction of WordCount from
> the Plain Text extractor. Though considering the speed difference, I
> think it is worth it.
>
>
> Diffs
> -----
>
> autotests/indexerextractortests.cpp 6b7c605
> autotests/simpleresult.h f3793b5
> src/extractionresult.h 76dfe59
> src/extractionresult.cpp 9bc7946
> src/extractors/plaintextextractor.cpp 5a38857
>
> Diff: https://git.reviewboard.kde.org/r/117996/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vishesh Handa
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117996/">https://git.reviewboard.kde.org/r/117996/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117996/diff/1/?file=271599#file271599line59" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/extractionresult.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QString ExtractionResult::inputUrl() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">59</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">ExtractionResult</span><span \
class="o">::</span><span class="n">append</span><span class="p">(</span><span \
class="k">const</span> <span class="n">QByteArray</span><span class="o">&</span> \
<span class="n">bytes</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK but then \
I don't get why you can compile this. You provide a definition of the \
pure-virtual declaration here, no? That's not going to compile, is it?
Generally, I'd say don't make it pure-virtual as you can provide a meaningful \
default-implementation here... Only for performance reasons would one want to \
reimplement it after all.</pre> </div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On May 5th, 2014, 2:01 p.m. UTC, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo and Milian Wolff.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated May 5, 2014, 2:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> Add an append(QByteArray) method to the ExtractionResult
This way plugins can choose to return the data in utf8 or as a QString,
and the clients can either just let the standard QString::fromUtf8
function do its magic, or implement some special handling if they wish.
This speeds up the PlainTextExtractor quite a bit (60msec vs 8.3msec)
Unfortunately, this meant discarding the extraction of WordCount from
the Plain Text extractor. Though considering the speed difference, I
think it is worth it.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/indexerextractortests.cpp <span style="color: \
grey">(6b7c605)</span></li>
<li>autotests/simpleresult.h <span style="color: grey">(f3793b5)</span></li>
<li>src/extractionresult.h <span style="color: grey">(76dfe59)</span></li>
<li>src/extractionresult.cpp <span style="color: grey">(9bc7946)</span></li>
<li>src/extractors/plaintextextractor.cpp <span style="color: \
grey">(5a38857)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117996/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic