From kde-devel Tue Apr 29 22:55:24 2014 From: "Michael Pyne" Date: Tue, 29 Apr 2014 22:55:24 +0000 To: kde-devel Subject: Re: Review Request 117829: do not raise unknown signal on windows Message-Id: <20140429225524.27257.98359 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-devel&m=139881217008731 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3454000873773469563==" --===============3454000873773469563== Content-Type: multipart/alternative; boundary="===============2026745609189754235==" --===============2026745609189754235== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On April 28, 2014, 12:42 p.m., Vishesh Handa wrote: > > src/file/autotest/fileindexingjob/extractor.cpp, line 76 > > > > > > Wouldn't exit just terminate the process normally? I was hoping to simulate a crash. If you want to simulate a crash portably, you might want to try abort(3), which is available in C since C89. I'm not sure what it does on Windows, but on POSIX it throws SIGABRT instead but that should be easy enough to adjust to. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117829/#review56738 ----------------------------------------------------------- On April 28, 2014, 9:54 a.m., Patrick Spendrin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117829/ > ----------------------------------------------------------- > > (Updated April 28, 2014, 9:54 a.m.) > > > Review request for Baloo and kdewin. > > > Repository: baloo > > > Description > ------- > > this signal is not available on windows. Also exit should behave in a similar way, so maybe exit can be used everywhere? > > > Diffs > ----- > > src/file/autotest/fileindexingjob/extractor.cpp a6d14d7 > > Diff: https://git.reviewboard.kde.org/r/117829/diff/ > > > Testing > ------- > > windows msvc 2010 > > > Thanks, > > Patrick Spendrin > > --===============2026745609189754235== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117829/

On April 28th, 2014, 12:42 p.m. UTC, Vishesh Handa wrote:
src/file/autotest/fileindexingjob/extractor.cpp (Diff revision 1)
int main(int argc, char* argv[])
76
            exit(-1);
Wouldn't exit just terminate the process normally? I was hoping to simulate a crash.

If you want to simulate a crash portably, you might want to try abort(3), which is available in C since C89. I'm not sure what it does on Windows, but on POSIX it throws SIGABRT instead but that should be easy enough to adjust to.

- Michael

On April 28th, 2014, 9:54 a.m. UTC, Patrick Spendrin wrote:

Review request for Baloo and kdewin.

By Patrick Spendrin.

Updated April 28, 2014, 9:54 a.m.

Repository: baloo

Description

this signal is not available on windows. Also exit should behave in a similar way, so maybe exit can be used everywhere?

Testing

windows msvc 2010

Diffs

src/file/autotest/fileindexingjob/extractor.cpp (a6d14d7)

--===============2026745609189754235==-- --===============3454000873773469563== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============3454000873773469563==--