From kde-devel Tue Apr 29 00:03:31 2014 From: "Patrick Spendrin" Date: Tue, 29 Apr 2014 00:03:31 +0000 To: kde-devel Subject: Re: Review Request 117832: use QFileInfo to also find hidden paths on windows Message-Id: <20140429000331.12926.16525 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-devel&m=139872997908377 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7861600854509733665==" --===============7861600854509733665== Content-Type: multipart/alternative; boundary="===============5025291763011207598==" --===============5025291763011207598== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117832/ ----------------------------------------------------------- (Updated April 29, 2014, 12:03 a.m.) Status ------ This change has been marked as submitted. Review request for Baloo and kdewin. Repository: baloo Description ------- hidden files on windows must not start with a . So instead use QFileInfo to correctly check that files are hidden and also modify the test and use the native function. Diffs ----- src/file/autotest/fileindexerconfigutils.h ab52f3b Diff: https://git.reviewboard.kde.org/r/117832/diff/ Testing ------- windows msvc 2010 Thanks, Patrick Spendrin --===============5025291763011207598== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117832/

This change has been marked as submitted.

Review request for Baloo and kdewin.

By Patrick Spendrin.

Updated April 29, 2014, 12:03 a.m.

Repository: baloo

Description

hidden files on windows must not start with a . So instead use QFileInfo to correctly check that files are hidden and also modify the test and use the native function.

Testing

windows msvc 2010

Diffs

src/file/autotest/fileindexerconfigutils.h (ab52f3b)

View Diff

--===============5025291763011207598==-- --===============7861600854509733665== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============7861600854509733665==--