[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 117845: rename test as another exists with the same name
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2014-04-28 15:51:59
Message-ID: 20140428155159.9428.76598 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117845/#review56771
-----------------------------------------------------------
Ship it!
Feel free to commit it after that.
src/file/tests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/117845/#comment39624>
I would prefer if you kept the same test name and used set_target_properties
Eg - set_target_properties(baloo_file_extractor_dummy
PROPERTIES OUTPUT_NAME baloo_file_extractor
)
- Vishesh Handa
On April 28, 2014, 3:33 p.m., Patrick Spendrin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117845/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 3:33 p.m.)
>
>
> Review request for Baloo and kdewin.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> rename test as another exists with the same name
>
>
> Diffs
> -----
>
> src/file/search/autotest/CMakeLists.txt 836ef2bfb29562aa36d8ebca8678932e5f01e0f3
> src/file/tests/CMakeLists.txt 7b914b2f6a9b37f5ed2397ef3cc9c38ec29aba0a
>
> Diff: https://git.reviewboard.kde.org/r/117845/diff/
>
>
> Testing
> -------
>
> msvc 2010
>
>
> Thanks,
>
> Patrick Spendrin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117845/">https://git.reviewboard.kde.org/r/117845/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Feel free to commit it \
after that.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117845/diff/1/?file=269043#file269043line18" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/file/tests/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">18</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="err">kde4_add_executable(<span \
class="hl">basic</span>indexingqueuetest</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">18</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="err">kde4_add_executable(indexingqueuetest</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would \
prefer if you kept the same test name and used set_target_properties
Eg - set_target_properties(baloo_file_extractor_dummy
PROPERTIES OUTPUT_NAME baloo_file_extractor
)
</pre>
</div>
<br />
<p>- Vishesh Handa</p>
<br />
<p>On April 28th, 2014, 3:33 p.m. UTC, Patrick Spendrin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo and kdewin.</div>
<div>By Patrick Spendrin.</div>
<p style="color: grey;"><i>Updated April 28, 2014, 3:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">rename test as another exists with the same name</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">msvc 2010</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/file/search/autotest/CMakeLists.txt <span style="color: \
grey">(836ef2bfb29562aa36d8ebca8678932e5f01e0f3)</span></li>
<li>src/file/tests/CMakeLists.txt <span style="color: \
grey">(7b914b2f6a9b37f5ed2397ef3cc9c38ec29aba0a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117845/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic