[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 117832: use QFileInfo to also find hidden paths on windows
From: "Patrick Spendrin" <ps_ml () gmx ! de>
Date: 2014-04-28 13:29:11
Message-ID: 20140428132911.9428.29207 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 28, 2014, 1:24 p.m., Reece Dunn wrote:
> > The *A Windows API variants use the ASCII (referred to as ANSI in the Windows \
> > docs), not UTF-8, encoding. Therefore, this will not work as expected for \
> > non-ASCII characters. This should use SetFileAttributeW with toUtf16.
The files used in the test use ascii encoding though, so it works.
I'll change it anyway though.
- Patrick
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117832/#review56750
-----------------------------------------------------------
On April 28, 2014, 10:05 a.m., Patrick Spendrin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117832/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 10:05 a.m.)
>
>
> Review request for Baloo and kdewin.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> hidden files on windows must not start with a . So instead use QFileInfo to \
> correctly check that files are hidden and also modify the test and use the native \
> function.
>
> Diffs
> -----
>
> src/file/autotest/fileindexerconfigutils.h ab52f3b
>
> Diff: https://git.reviewboard.kde.org/r/117832/diff/
>
>
> Testing
> -------
>
> windows msvc 2010
>
>
> Thanks,
>
> Patrick Spendrin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117832/">https://git.reviewboard.kde.org/r/117832/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 28th, 2014, 1:24 p.m. UTC, <b>Reece \
Dunn</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The *A Windows API variants use the ASCII (referred to as ANSI in the \
Windows docs), not UTF-8, encoding. Therefore, this will not work as expected for \
non-ASCII characters. This should use SetFileAttributeW with toUtf16. </pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The files used in the \
test use ascii encoding though, so it works. I'll change it anyway though.</pre>
<br />
<p>- Patrick</p>
<br />
<p>On April 28th, 2014, 10:05 a.m. UTC, Patrick Spendrin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo and kdewin.</div>
<div>By Patrick Spendrin.</div>
<p style="color: grey;"><i>Updated April 28, 2014, 10:05 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">hidden files on windows must not start with a . So instead use QFileInfo \
to correctly check that files are hidden and also modify the test and use the native \
function.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">windows msvc 2010</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/file/autotest/fileindexerconfigutils.h <span style="color: \
grey">(ab52f3b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117832/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic