From kde-devel Sat Apr 19 09:52:32 2014 From: =?UTF-8?Q?Thomas_L=C3=BCbking?= Date: Sat, 19 Apr 2014 09:52:32 +0000 To: kde-devel Subject: Re: meinproc4 on Mac, KLocale (was Re: What to test for 4.13?) Message-Id: X-MARC-Message: https://marc.info/?l=kde-devel&m=139790117523858 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4814738742514015380==" --===============4814738742514015380== Content-Type: multipart/alternative; boundary=001a11c25d30a1e92504f76239b8 --001a11c25d30a1e92504f76239b8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am Samstag, 19. April 2014 schrieb Ian Wadham : > On 18/04/2014, at 4:58 AM, Thomas L=C3=BCbking wrote: >> If removing the KLocale() constructor avoids it, i'm fairly sure it will be the bogus CFStringGetLength call, so to me it would seem more reasonable to protect convert_CFString_to_QString >> >> kdelibs/kdecore/kernel/kkernel_mac.cpp >> ----------- >> >> QString convert_CFString_to_QString(CFStringRef str) { >> + if (str =3D=3D NULL) { >> + return QString(); >> + } >> >> eventually print a warning (while i've no idea what this condition implies, like eg. a broken setup. It could be a bug in CFStringRef or CFLocaleGetValue or either isn't re-entrant or whatever) > > That is undoubtedly worth doing, but might not solve the whole problem. > See my reply to Luigi. Briefly, this is where the crash was in the only > backtrace we have ever had. There might be other crash-points. That will then expose and be fixable =3D) Of course altering the build script to not fail but write a "foobar.docbook.failed" warning (that ideally contains a coredump) would be a workaround to harden the process. (i've no insight into docbook creation - i google anyway ;-) >> And no, forking the application seems the worst option (remember Ian, you'd have to maintain that fork ;-) > > Not in my philosophy, Horatio =E2=80=A6 :-) > > Of course, if I made such a change I would take responsibility for it for as long as > I am able, but what then? I am getting rather old now =E2=80=A6 > > In my philosophy, also in the salaried part of the computer industry and FAIK in free > products like Firefox, maintenance is a *group* responsibility. Thanks for the lesson, but as German, let me be the Mephisto: That is certainly right. How many able mac developers are there in the group of interested people right now, again? >-) Cheers, Thomas --001a11c25d30a1e92504f76239b8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am Samstag, 19. April 2014 schrieb Ian Wadham :
> On 18/04/2014, at 4= :58 AM, Thomas L=C3=BCbking wrote:

>> If removing the KLocale(= ) constructor avoids it, i'm fairly sure it will be the bogus CFStringG= etLength call, so to me it would seem more reasonable to protect convert_CF= String_to_QString
>>
>> kdelibs/kdecore/kernel/kkernel_mac.cpp
>> ---= --------
>>
>> QString convert_CFString_to_QString(CFStri= ngRef str) {
>> + =C2=A0 =C2=A0if (str =3D=3D NULL) {
>> = + =C2=A0 =C2=A0 =C2=A0 =C2=A0return QString();
>> + =C2=A0 =C2=A0}
>>
>> eventually print a warnin= g (while i've no idea what this condition implies, like eg. a broken se= tup. It could be a bug in CFStringRef or CFLocaleGetValue or either isn'= ;t re-entrant or whatever)
>
> That is undoubtedly worth doing, but might not solve the whole= problem.
> See my reply to Luigi. =C2=A0Briefly, this is where the c= rash was in the only
> backtrace we have ever had. There might be oth= er crash-points.
That will then expose and be fixable =3D)
Of course altering the build s= cript to not fail but write a "foobar.docbook.failed" warning (th= at ideally contains a coredump) would be a workaround to harden the process= . (i've no insight into docbook creation - i google anyway ;-)

>> And no, forking the application seems the worst option (rememb= er Ian, you'd have to maintain that fork ;-)
>
> Not in my = philosophy, Horatio =E2=80=A6 :-)
>
> Of course, if I made such= a change I would take responsibility for it for as long as
> I am able, but what then? =C2=A0I am getting rather old now =E2=80=A6<= br>>
> In my philosophy, also in the salaried part of the computer= industry and FAIK in free
> products like Firefox, maintenance is a = *group* responsibility.

Thanks for the lesson, but as German, let me be the Mephisto:

Th= at is certainly right.
How many able mac developers are there in the gro= up of interested people right now, again?

>-)

Cheers,
Thomas --001a11c25d30a1e92504f76239b8-- --===============4814738742514015380== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============4814738742514015380==--