From kde-devel Tue Apr 15 01:44:41 2014 From: Lindsay Mathieson Date: Tue, 15 Apr 2014 01:44:41 +0000 To: kde-devel Subject: Re: Review Request 117420: Fixes issue with full path of excluded directory not being shown Message-Id: X-MARC-Message: https://marc.info/?l=kde-devel&m=139752631011089 Do you still want this Vishesh? On 15 April 2014 07:10, Lindsay Mathieson wrote: > Do you still want this Vishesh? > > On Sat, 12 Apr 2014 11:02:58 PM Lindsay Mathieson wrote: >> > On April 13, 2014, 4 a.m., Vishesh Handa wrote: >> > > src/file/kcm/folderselectionwidget.cpp, line 295 >> > > > > > 14line295>> > >> > > I've given this more thought, and I dislike the '~/'. Please remove >> > > it. >> > > >> > > The rest is fine. >> > > >> > > I can ask for an exception from the release team and ship this with >> > > 4.13 >> > >> > Lindsay Mathieson wrote: >> > Trouble is, if you then add $HOME as an exclude path it just displays >> > the Home Icon and no string at all. Would "HomeIcon/" be better? >> I've taken the liberty of modifying the iconName() func so that it returns >> the home icon or drive icon for any path starting with home or mount point >> respectively. Easy enough to undo if you do not like it. >> >> >> - Lindsay >> >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://git.reviewboard.kde.org/r/117420/#review55527 >> ----------------------------------------------------------- >> >> On April 13, 2014, 9:01 a.m., Lindsay Mathieson wrote: >> > ----------------------------------------------------------- >> > This is an automatically generated e-mail. To reply, visit: >> > https://git.reviewboard.kde.org/r/117420/ >> > ----------------------------------------------------------- >> > >> > (Updated April 13, 2014, 9:01 a.m.) >> > >> > >> > Review request for Baloo. >> > >> > >> > Bugs: 333155 >> > >> > http://bugs.kde.org/show_bug.cgi?id=333155 >> > >> > Repository: baloo >> > >> > >> > Description >> > ------- >> > >> > Displays full path of excluded directories - reduce possibilities of >> > confusion and ambiguity. >> > >> > >> > Diffs >> > ----- >> > >> > src/file/kcm/folderselectionwidget.h 5e4e661 >> > src/file/kcm/folderselectionwidget.cpp bc87a33 >> > >> > Diff: https://git.reviewboard.kde.org/r/117420/diff/ >> > >> > >> > Testing >> > ------- >> > >> > Build, installed - opens KCM module, full paths displayed, with ample >> > room. >> > >> > >> > Thanks, >> > >> > Lindsay Mathieson > > -- > Lindsay -- Lindsay >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<