--===============0581068754877843342== Content-Type: multipart/alternative; boundary="===============0922601406775992516==" --===============0922601406775992516== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On April 13, 2014, 4 a.m., Vishesh Handa wrote: > > src/file/kcm/folderselectionwidget.cpp, line 295 > > > > > > I've given this more thought, and I dislike the '~/'. Please remove it. > > > > The rest is fine. > > > > I can ask for an exception from the release team and ship this with 4.13 > > Lindsay Mathieson wrote: > Trouble is, if you then add $HOME as an exclude path it just displays the Home Icon and no string at all. Would "HomeIcon/" be better? I've taken the liberty of modifying the iconName() func so that it returns the home icon or drive icon for any path starting with home or mount point respectively. Easy enough to undo if you do not like it. - Lindsay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117420/#review55527 ----------------------------------------------------------- On April 13, 2014, 9:01 a.m., Lindsay Mathieson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117420/ > ----------------------------------------------------------- > > (Updated April 13, 2014, 9:01 a.m.) > > > Review request for Baloo. > > > Bugs: 333155 > http://bugs.kde.org/show_bug.cgi?id=333155 > > > Repository: baloo > > > Description > ------- > > Displays full path of excluded directories - reduce possibilities of confusion and ambiguity. > > > Diffs > ----- > > src/file/kcm/folderselectionwidget.h 5e4e661 > src/file/kcm/folderselectionwidget.cpp bc87a33 > > Diff: https://git.reviewboard.kde.org/r/117420/diff/ > > > Testing > ------- > > Build, installed - opens KCM module, full paths displayed, with ample room. > > > Thanks, > > Lindsay Mathieson > > --===============0922601406775992516== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117420/

On April 13th, 2014, 4 a.m. EST, Vishesh Handa wrote:
src/file/kcm/folderselectionwidget.cpp (Diff revisions 2 - 3)
295
        return "[~]/" + url.mid(QDir::homePath().length() + 1);
I've given this more thought, and I dislike the '~/'. Please remove it.

The rest is fine.

I can ask for an exception from the release team and ship this with 4.13
On April 13th, 2014, 8 a.m. EST, Lindsay Mathieson wrote:
Trouble is, if you then add $HOME as an exclude path it just displays the Home Icon and no string at all. Would "HomeIcon/" be better?

I've taken the liberty of modifying the iconName() func so that it returns the home icon or drive icon for any path starting with home or mount point respectively. Easy enough to undo if you do not like it.

- Lindsay

On April 13th, 2014, 9:01 a.m. EST, Lindsay Mathieson wrote:

Review request for Baloo.

By Lindsay Mathieson.

Updated April 13, 2014, 9:01 a.m.

Bugs: 333155

Repository: baloo

Description

Displays full path of excluded directories - reduce possibilities of confusion and ambiguity.

Testing

Build, installed - opens KCM module, full paths displayed, with ample room.

Diffs

src/file/kcm/folderselectionwidget.h (5e4e661)
src/file/kcm/folderselectionwidget.cpp (bc87a33)

--===============0922601406775992516==-- --===============0581068754877843342== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============0581068754877843342==--