--===============8131983755867333248== Content-Type: multipart/alternative; boundary="===============1046628392758447689==" --===============1046628392758447689== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117436/ ----------------------------------------------------------- (Updated April 12, 2014, 8:09 a.m.) Review request for Baloo. Changes ------- Less kludgy implementation of homePath() Repository: baloo Description ------- Part of the KCM code assumes the users home dir is under "/home", which is not always the cause in linux - e.g OpenSUSE with AD Authentication uses a /home/DOMAIN hierarchy. Other systems use /opt. Not to mention windows etc. The code adds a function homeRoot() which returns the parent directory of the uses home directory. Diffs (updated) ----- src/file/kcm/folderselectionwidget.cpp bc87a33 Diff: https://git.reviewboard.kde.org/r/117436/diff/ Testing ------- Built, installed. Adding paths to the exclude lists still recognise the home root. Thanks, Lindsay Mathieson --===============1046628392758447689== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117436/

Review request for Baloo.

By Lindsay Mathieson.

Updated April 12, 2014, 8:09 a.m.

Changes

Less kludgy implementation of homePath()

Repository: baloo

Description

Part of the KCM code assumes the users home dir is under "/home", which is not always the cause in linux - e.g OpenSUSE with AD Authentication uses a /home/DOMAIN hierarchy. Other systems use /opt. Not to mention windows etc.

The code adds a function homeRoot() which returns the parent directory of the uses home directory.

Testing

Built, installed. Adding paths to the exclude lists still recognise the home root.

Diffs (updated)

src/file/kcm/folderselectionwidget.cpp (bc87a33)

View Diff

--===============1046628392758447689==-- --===============8131983755867333248== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============8131983755867333248==--