[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 117436: Doesn't assume that the users home directory is under /home
From: "Kevin Krammer" <krammer () kde ! org>
Date: 2014-04-11 15:57:05
Message-ID: 20140411155705.29770.90493 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117436/#review55461
-----------------------------------------------------------
src/file/kcm/folderselectionwidget.cpp
<https://git.reviewboard.kde.org/r/117436/#comment38601>
maybe QFileInfo(QDir::homePath()).absolutPath()
src/file/kcm/folderselectionwidget.cpp
<https://git.reviewboard.kde.org/r/117436/#comment38602>
p is a rather bad variable name :)
the question is what does this check protect against?
Might be easier to check if "url" is a prefix of QDir::homePath() if this \
protects against $HOME being excluded
- Kevin Krammer
On April 8, 2014, 1 p.m., Lindsay Mathieson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117436/
> -----------------------------------------------------------
>
> (Updated April 8, 2014, 1 p.m.)
>
>
> Review request for Baloo.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Part of the KCM code assumes the users home dir is under "/home", which is not \
> always the cause in linux - e.g OpenSUSE with AD Authentication uses a /home/DOMAIN \
> hierarchy. Other systems use /opt. Not to mention windows etc.
> The code adds a function homeRoot() which returns the parent directory of the uses \
> home directory.
>
> Diffs
> -----
>
> src/file/kcm/folderselectionwidget.cpp bc87a33
>
> Diff: https://git.reviewboard.kde.org/r/117436/diff/
>
>
> Testing
> -------
>
> Built, installed. Adding paths to the exclude lists still recognise the home root.
>
>
> Thanks,
>
> Lindsay Mathieson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117436/">https://git.reviewboard.kde.org/r/117436/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117436/diff/1/?file=263434#file263434line198" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/file/kcm/folderselectionwidget.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">198</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="n">QDir</span><span class="o">::</span><span \
class="n">cleanPath</span><span class="p">(</span><span class="n">QDir</span><span \
class="o">::</span><span class="n">homePath</span><span class="p">()</span> <span \
class="o">+</span> <span class="s">"/.."</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">maybe \
QFileInfo(QDir::homePath()).absolutPath() </pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117436/diff/1/?file=263434#file263434line210" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/file/kcm/folderselectionwidget.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">205</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> \
<span class="p">(</span><span class="n">url</span> <span class="o">==</span> <span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"/home"</span><span class="p">))</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">210</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QString</span> <span class="n">p</span> <span class="o">=</span> <span \
class="n">homeRoot</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">p is a \
rather bad variable name :) the question is what does this check protect against?
Might be easier to check if "url" is a prefix of QDir::homePath() if this \
protects against $HOME being excluded</pre> </div>
<br />
<p>- Kevin Krammer</p>
<br />
<p>On April 8th, 2014, 1 p.m. UTC, Lindsay Mathieson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo.</div>
<div>By Lindsay Mathieson.</div>
<p style="color: grey;"><i>Updated April 8, 2014, 1 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Part of the KCM code assumes the users home dir is under \
"/home", which is not always the cause in linux - e.g OpenSUSE with AD \
Authentication uses a /home/DOMAIN hierarchy. Other systems use /opt. Not to mention \
windows etc.
The code adds a function homeRoot() which returns the parent directory of the uses \
home directory.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built, installed. Adding paths to the exclude lists still recognise the \
home root.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/file/kcm/folderselectionwidget.cpp <span style="color: \
grey">(bc87a33)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117436/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic