From kde-devel  Fri Apr 11 14:47:24 2014
From: Lindsay Mathieson <lindsay.mathieson () gmail ! com>
Date: Fri, 11 Apr 2014 14:47:24 +0000
To: kde-devel
Subject: Re: Review Request 117436: Doesn't assume that the users home directory is under /home
Message-Id: <3822654.UkN688KQjG () lindsay-office>
X-MARC-Message: https://marc.info/?l=kde-devel&m=139722768719342

Unless I'm having a complete brain fart on the subject, this is a fix for a 
small but legit problem isn't it?



On Tue, 8 Apr 2014 01:00:20 PM Lindsay Mathieson wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117436/
> -----------------------------------------------------------
> 
> (Updated April 8, 2014, 11 p.m.)
> 
> 
> Review request for Baloo.
> 
> 
> Repository: baloo
> 
> 
> Description (updated)
> -------
> 
> Part of the KCM code assumes the users home dir is under "/home", which is
> not always the cause in linux - e.g OpenSUSE with AD Authentication uses a
> /home/DOMAIN hierarchy. Other systems use /opt. Not to mention windows etc.
> 
> The code adds a function homeRoot() which returns the parent directory of
> the uses home directory.
> 
> 
> Diffs
> -----
> 
>   src/file/kcm/folderselectionwidget.cpp bc87a33
> 
> Diff: https://git.reviewboard.kde.org/r/117436/diff/
> 
> 
> Testing
> -------
> 
> Built, installed. Adding paths to the exclude lists still recognise the home
> root.
> 
> 
> Thanks,
> 
> Lindsay Mathieson

-- 
Lindsay

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<