[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 117441: Raise match ceiling in the KRunner plugin from 5 to 10
From: "Eike Hein" <hein () kde ! org>
Date: 2014-04-09 13:56:06
Message-ID: 20140409135606.4909.25994 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 9, 2014, 1:46 p.m., Vishesh Handa wrote:
> >
Pushed as 8df8be6ac.
- Eike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117441/#review55289
-----------------------------------------------------------
On April 9, 2014, 1:55 p.m., Eike Hein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117441/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 1:55 p.m.)
>
>
> Review request for Baloo and Vishesh Handa.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Raising the ceiling would make the Baloo runner more useful in KRunner frontends \
> like Homerun and Homerun Kicker.
> While it might make sense for Homerun to use Baloo directly, this:
>
> a) Isn't currently possible in time for SC 4.13 to be released.
>
> b) Doesn't prevent users from using either the "KRunner" source in Homerun, or the \
> "Runner: Desktop Search" source. The former is the only way to get a combined \
> listing with other KRunner plugins, which might be desirable for some users.
> c) Some users already have the above in their configs, and Baloo is the natural \
> upgrade path for them (and in fact, the just-released Homerun 1.2.3 does this \
> automatically). It'd nice if installing SC 4.13 doesn't degrade their experience -- \
> and 10 was the ceiling in the old nepomuksearch runner.
> It would be awesome if we could get this in before today's 4.13 tag.
>
>
> Diffs
> -----
>
> src/runner/baloosearchrunner.cpp b62cb8b
>
> Diff: https://git.reviewboard.kde.org/r/117441/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eike Hein
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117441/">https://git.reviewboard.kde.org/r/117441/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pushed as \
8df8be6ac.</pre> <br />
<p>- Eike</p>
<br />
<p>On April 9th, 2014, 1:55 p.m. UTC, Eike Hein wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Eike Hein.</div>
<p style="color: grey;"><i>Updated April 9, 2014, 1:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Raising the ceiling would make the Baloo runner more useful in KRunner \
frontends like Homerun and Homerun Kicker.
While it might make sense for Homerun to use Baloo directly, this:
a) Isn't currently possible in time for SC 4.13 to be released.
b) Doesn't prevent users from using either the "KRunner" source in \
Homerun, or the "Runner: Desktop Search" source. The former is the only way \
to get a combined listing with other KRunner plugins, which might be desirable for \
some users.
c) Some users already have the above in their configs, and Baloo is the natural \
upgrade path for them (and in fact, the just-released Homerun 1.2.3 does this \
automatically). It'd nice if installing SC 4.13 doesn't degrade their \
experience -- and 10 was the ceiling in the old nepomuksearch runner.
It would be awesome if we could get this in before today's 4.13 tag.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/runner/baloosearchrunner.cpp <span style="color: grey">(b62cb8b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117441/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic