'Re: Review Request 117436: Doesn't assume that the users home directory is under /home'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 117436: Doesn't assume that the users home directory is under /home
From:       "Lindsay Mathieson" <lindsay.mathieson () gmail ! com>
Date:       2014-04-08 13:00:20
Message-ID: 20140408130020.11689.65027 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117436/
-----------------------------------------------------------

(Updated April 8, 2014, 11 p.m.)

Review request for Baloo.

Repository: baloo

Description (updated)
-------

Part of the KCM code assumes the users home dir is under "/home", which is not always \
the cause in linux - e.g OpenSUSE with AD Authentication uses a /home/DOMAIN \
hierarchy. Other systems use /opt. Not to mention windows etc.

The code adds a function homeRoot() which returns the parent directory of the uses \
home directory.

Diffs
-----

  src/file/kcm/folderselectionwidget.cpp bc87a33 

Diff: https://git.reviewboard.kde.org/r/117436/diff/

Testing
-------

Built, installed. Adding paths to the exclude lists still recognise the home root.

Thanks,

Lindsay Mathieson

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117436/">https://git.reviewboard.kde.org/r/117436/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Baloo.</div>
<div>By Lindsay Mathieson.</div>

<p style="color: grey;"><i>Updated April 8, 2014, 11 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Part of the KCM code assumes the users home dir is under \
&quot;/home&quot;, which is not always the cause in linux - e.g OpenSUSE with AD \
Authentication uses a /home/DOMAIN hierarchy. Other systems use /opt. Not to mention \
windows etc.

The code adds a function homeRoot() which returns the parent directory of the uses \
home directory.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built, installed. Adding paths to the exclude lists still recognise the \
home root.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/file/kcm/folderselectionwidget.cpp <span style="color: \
grey">(bc87a33)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117436/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 