[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 117420: Fixes issue with full path of excluded directory not being shown
From: "Wyatt Epp" <wyatt.epp () gmail ! com>
Date: 2014-04-07 14:43:28
Message-ID: 20140407144328.26935.68620 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 7, 2014, 1:23 p.m., Vishesh Handa wrote:
> > I'm not inclined to accept this patch, you know my rationale. If you really want \
> > this then please only show the full path when there are duplicates.
> > Also, please contact the usability team and run it by them.
>
> Lindsay Mathieson wrote:
> I thought you were going to ask them about, but ok - will do.
>
> "If you really want this then please only show the full path when there are \
> duplicates."
> Even more inconsistent.
Unfortunately paths are the most readily-available _human readable_ unique identifier \
that current filesystems have for preventing filename collisions, and the high \
incidence of duplication in file naming makes it abundantly clear that users rely on \
this. On the other hand, showing the full path is kind of ugly and the repeating \
pattern of the prefix part makes it much more likely for users to skim and miss \
something important that was unintended. (I haven't seen Vishesh's rationale \
anywhere, but I'm guessing it's something in that vein?)
A possible compromise: show the path relative to the user's home. This will \
generally distill it down to the specifier that users are familiar with in their own \
usage. One class of potential degenerate cases concerns paths outside of home, such \
as devices mounted in [/run]/media. For this, I beleive it would work to instead \
display relative to the mount point as long as it's clearly denoted in a \
human-readable form (e.g. device label).
Regards,
Wyatt
- Wyatt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117420/#review55153
-----------------------------------------------------------
On April 7, 2014, 11:59 a.m., Lindsay Mathieson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117420/
> -----------------------------------------------------------
>
> (Updated April 7, 2014, 11:59 a.m.)
>
>
> Review request for Baloo and Nepomuk.
>
>
> Bugs: 333155
> http://bugs.kde.org/show_bug.cgi?id=333155
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Displays full path of excluded directories - reduce possibilities of confusion and \
> ambiguity.
>
> Diffs
> -----
>
> src/file/kcm/folderselectionwidget.cpp bc87a33
>
> Diff: https://git.reviewboard.kde.org/r/117420/diff/
>
>
> Testing
> -------
>
> Build, installed - opens KCM module, full paths displayed, with ample room.
>
>
> Thanks,
>
> Lindsay Mathieson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117420/">https://git.reviewboard.kde.org/r/117420/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 7th, 2014, 1:23 p.m. UTC, <b>Vishesh \
Handa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm not inclined to accept this patch, you know my rationale. If you \
really want this then please only show the full path when there are duplicates.
Also, please contact the usability team and run it by them.</pre>
</blockquote>
<p>On April 7th, 2014, 1:35 p.m. UTC, <b>Lindsay Mathieson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I thought you were going \
to ask them about, but ok - will do.
"If you really want this then please only show the full path when there are \
duplicates."
Even more inconsistent.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unfortunately paths are \
the most readily-available _human readable_ unique identifier that current \
filesystems have for preventing filename collisions, and the high incidence of \
duplication in file naming makes it abundantly clear that users rely on this. On the \
other hand, showing the full path is kind of ugly and the repeating pattern of the \
prefix part makes it much more likely for users to skim and miss something important \
that was unintended. (I haven't seen Vishesh's rationale anywhere, but \
I'm guessing it's something in that vein?)
A possible compromise: show the path relative to the user's home. This will \
generally distill it down to the specifier that users are familiar with in their own \
usage. One class of potential degenerate cases concerns paths outside of home, such \
as devices mounted in [/run]/media. For this, I beleive it would work to instead \
display relative to the mount point as long as it's clearly denoted in a \
human-readable form (e.g. device label).
Regards,
Wyatt</pre>
<br />
<p>- Wyatt</p>
<br />
<p>On April 7th, 2014, 11:59 a.m. UTC, Lindsay Mathieson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo and Nepomuk.</div>
<div>By Lindsay Mathieson.</div>
<p style="color: grey;"><i>Updated April 7, 2014, 11:59 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=333155">333155</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Displays full path of excluded directories - reduce possibilities of \
confusion and ambiguity.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Build, installed - opens KCM module, full paths displayed, with ample \
room.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/file/kcm/folderselectionwidget.cpp <span style="color: \
grey">(bc87a33)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117420/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic