[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 117420: Fixes issue with full path of excluded directory not being shown
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2014-04-07 13:23:12
Message-ID: 20140407132312.29615.48542 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117420/#review55153
-----------------------------------------------------------
I'm not inclined to accept this patch, you know my rationale. If you really want this \
then please only show the full path when there are duplicates.
Also, please contact the usability team and run it by them.
src/file/kcm/folderselectionwidget.cpp
<https://git.reviewboard.kde.org/r/117420/#comment38447>
What about this one?
- Vishesh Handa
On April 7, 2014, 11:59 a.m., Lindsay Mathieson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117420/
> -----------------------------------------------------------
>
> (Updated April 7, 2014, 11:59 a.m.)
>
>
> Review request for Baloo and Nepomuk.
>
>
> Bugs: 333155
> http://bugs.kde.org/show_bug.cgi?id=333155
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Displays full path of excluded directories - reduce possibilities of confusion and \
> ambiguity.
>
> Diffs
> -----
>
> src/file/kcm/folderselectionwidget.cpp bc87a33
>
> Diff: https://git.reviewboard.kde.org/r/117420/diff/
>
>
> Testing
> -------
>
> Build, installed - opens KCM module, full paths displayed, with ample room.
>
>
> Thanks,
>
> Lindsay Mathieson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117420/">https://git.reviewboard.kde.org/r/117420/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not inclined to \
accept this patch, you know my rationale. If you really want this then please only \
show the full path when there are duplicates.
Also, please contact the usability team and run it by them.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117420/diff/1/?file=263308#file263308line254" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/file/kcm/folderselectionwidget.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
FolderSelectionWidget::slotAddButtonClicked()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">254</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QString</span> <span class="n">display</span> <span class="o">=</span> \
<span class="n">KUrl</span><span class="p">(</span><span class="n">QUrl</span><span \
class="o">::</span><span class="n">fromLocalFile</span><span class="p">(</span><span \
class="n">url</span><span class="p">)).</span><span class="n">fileName</span><span \
class="p">();</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">254</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span \
class="n">display</span> <span class="o">=</span> <span class="n">KUrl</span><span \
class="p">(</span><span class="n">QUrl</span><span class="o">::</span><span \
class="n">fromLocalFile</span><span class="p">(</span><span class="n">url</span><span \
class="p">)).</span><span class="n">fileName</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What about \
this one?</pre> </div>
<br />
<p>- Vishesh Handa</p>
<br />
<p>On April 7th, 2014, 11:59 a.m. UTC, Lindsay Mathieson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo and Nepomuk.</div>
<div>By Lindsay Mathieson.</div>
<p style="color: grey;"><i>Updated April 7, 2014, 11:59 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=333155">333155</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Displays full path of excluded directories - reduce possibilities of \
confusion and ambiguity.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Build, installed - opens KCM module, full paths displayed, with ample \
room.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/file/kcm/folderselectionwidget.cpp <span style="color: \
grey">(bc87a33)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117420/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic