[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 117187: [Baloo] cmake: Introduce a config.h to use non-standard features conditio
From: "Commit Hook" <null () kde ! org>
Date: 2014-03-30 16:02:07
Message-ID: 20140330160207.20889.53724 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117187/#review54623
-----------------------------------------------------------
This review has been submitted with commit 06aa36ed71df4f83cdbfdfe09ac2f15515323b52 \
by Raphael Kubo da Costa to branch master.
- Commit Hook
On March 30, 2014, 11:45 a.m., Raphael Kubo da Costa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117187/
> -----------------------------------------------------------
>
> (Updated March 30, 2014, 11:45 a.m.)
>
>
> Review request for Baloo and Vishesh Handa.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> malloc_trim(3) is a GNU extension and thus should not be used
> unconditionally.
>
> Solve this problem by adding more checks to ConfigureChecks.cmake and using
> a config.h so that we only use non-standard features if their presence has
> been detected at configuration time.
>
>
> Diffs
> -----
>
> CMakeLists.txt 977eaf7e99da7742d5ea87ecb10df8c2355f81db
> ConfigureChecks.cmake 34db1e47338002d83250c5e3276bf207c477c30f
> config.h.cmake PRE-CREATION
> src/xapian/xapiandatabase.cpp d139ea70e60236a91e716e8ace03f4e01bb55706
>
> Diff: https://git.reviewboard.kde.org/r/117187/diff/
>
>
> Testing
> -------
>
> I can build baloo on FreeBSD again, all tests pass.
>
>
> Thanks,
>
> Raphael Kubo da Costa
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117187/">https://git.reviewboard.kde.org/r/117187/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 06aa36ed71df4f83cdbfdfe09ac2f15515323b52 by Raphael Kubo da \
Costa to branch master.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On March 30th, 2014, 11:45 a.m. UTC, Raphael Kubo da Costa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Raphael Kubo da Costa.</div>
<p style="color: grey;"><i>Updated March 30, 2014, 11:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">malloc_trim(3) is a GNU extension and thus should not be used \
unconditionally.
Solve this problem by adding more checks to ConfigureChecks.cmake and using
a config.h so that we only use non-standard features if their presence has
been detected at configuration time.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I can build baloo on FreeBSD again, all tests pass.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(977eaf7e99da7742d5ea87ecb10df8c2355f81db)</span></li>
<li>ConfigureChecks.cmake <span style="color: \
grey">(34db1e47338002d83250c5e3276bf207c477c30f)</span></li>
<li>config.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/xapian/xapiandatabase.cpp <span style="color: \
grey">(d139ea70e60236a91e716e8ace03f4e01bb55706)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117187/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic