From kde-devel Sun Mar 30 11:45:39 2014 From: "Raphael Kubo da Costa" Date: Sun, 30 Mar 2014 11:45:39 +0000 To: kde-devel Subject: Review Request 117187: [Baloo] cmake: Introduce a config.h to use non-standard features conditionall Message-Id: <20140330114539.20889.34810 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-devel&m=139617997217688 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6186818109260051733==" --===============6186818109260051733== Content-Type: multipart/alternative; boundary="===============6078652381939547568==" --===============6078652381939547568== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117187/ ----------------------------------------------------------- Review request for Baloo and Vishesh Handa. Repository: baloo Description ------- malloc_trim(3) is a GNU extension and thus should not be used unconditionally. Solve this problem by adding more checks to ConfigureChecks.cmake and using a config.h so that we only use non-standard features if their presence has been detected at configuration time. Diffs ----- CMakeLists.txt 977eaf7e99da7742d5ea87ecb10df8c2355f81db ConfigureChecks.cmake 34db1e47338002d83250c5e3276bf207c477c30f config.h.cmake PRE-CREATION src/xapian/xapiandatabase.cpp d139ea70e60236a91e716e8ace03f4e01bb55706 Diff: https://git.reviewboard.kde.org/r/117187/diff/ Testing ------- I can build baloo on FreeBSD again, all tests pass. Thanks, Raphael Kubo da Costa --===============6078652381939547568== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117187/

Review request for Baloo and Vishesh Handa.

By Raphael Kubo da Costa.

Repository: baloo

Description

malloc_trim(3) is a GNU extension and thus should not be used
unconditionally.

Solve this problem by adding more checks to ConfigureChecks.cmake and using
a config.h so that we only use non-standard features if their presence has
been detected at configuration time.

Testing

I can build baloo on FreeBSD again, all tests pass.

Diffs

CMakeLists.txt (977eaf7e99da7742d5ea87ecb10df8c2355f81db)
ConfigureChecks.cmake (34db1e47338002d83250c5e3276bf207c477c30f)
config.h.cmake (PRE-CREATION)
src/xapian/xapiandatabase.cpp (d139ea70e60236a91e716e8ace03f4e01bb55706)

View Diff

--===============6078652381939547568==-- --===============6186818109260051733== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============6186818109260051733==--