From kde-devel Fri Mar 28 16:53:14 2014 From: "David Faure" Date: Fri, 28 Mar 2014 16:53:14 +0000 To: kde-devel Subject: Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo Message-Id: <20140328165314.25923.75246 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-devel&m=139602567909426 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3786457591652336054==" --===============3786457591652336054== Content-Type: multipart/alternative; boundary="===============7746123964218342073==" --===============7746123964218342073== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/#review54469 ----------------------------------------------------------- kdeui/kmessagewidgetdemo/window.cpp Use setPlaceHolderText() instead. - David Faure On Jan. 16, 2014, 7:30 p.m., Laurent Navet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114933/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 7:30 p.m.) > > > Review request for KDE Examples and Sune Vuorela. > > > Repository: kdeexamples > > > Description > ------- > > This is part of Google Code-IN Contest. > As I'm no more student, I've waited for the end of the contest to work on it. > > Comments appreciated, > > > Diffs > ----- > > kdeui/kmessagewidgetdemo/CMakeLists.txt 12ef4ac > kdeui/kmessagewidgetdemo/main.cpp d3a5bf0 > kdeui/kmessagewidgetdemo/window.h d3a67c8 > kdeui/kmessagewidgetdemo/window.cpp 9786da6 > > Diff: https://git.reviewboard.kde.org/r/114933/diff/ > > > Testing > ------- > > Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit I've commented the line. > > > Thanks, > > Laurent Navet > > --===============7746123964218342073== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/

kdeui/kmessagewidgetdemo/window.cpp (Diff revision 3)
79	m_edit->setClickMessage(i18n("Use default text"));	79	// m_edit->setClickMessage(i18n("Use default text"));

Use setPlaceHolderText() instead.

- David Faure

On January 16th, 2014, 7:30 p.m. UTC, Laurent Navet wrote:

Review request for KDE Examples and Sune Vuorela.

By Laurent Navet.

Updated Jan. 16, 2014, 7:30 p.m.

Repository: kdeexamples

Description

This is part of Google Code-IN Contest.
As I'm no more student, I've waited for the end of the contest to work on it.

Comments appreciated,

Testing

Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit I've commented the line.

Diffs

kdeui/kmessagewidgetdemo/CMakeLists.txt (12ef4ac)
kdeui/kmessagewidgetdemo/main.cpp (d3a5bf0)
kdeui/kmessagewidgetdemo/window.h (d3a67c8)
kdeui/kmessagewidgetdemo/window.cpp (9786da6)

View Diff

--===============7746123964218342073==-- --===============3786457591652336054== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============3786457591652336054==--