[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 117085: Add user data in Baloo::Term
From: "Commit Hook" <null () kde ! org>
Date: 2014-03-26 14:28:53
Message-ID: 20140326142853.24148.76886 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117085/#review54207
-----------------------------------------------------------
This review has been submitted with commit e75f396a0ab9453c9d5c4550f5125542b2e009f2 \
by Denis Steckelmacher to branch KDE/4.13.
- Commit Hook
On March 26, 2014, 1:45 p.m., Denis Steckelmacher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117085/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 1:45 p.m.)
>
>
> Review request for Baloo.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> This patch adds two methods in Baloo::Term: setUserData and userData. They can be \
> used to associate arbitrary QVariants to terms. The data is not serialized to JSON \
> nor read back when the term is deserialized.
> The primary use of these two methods is to allow the user query parser to store the \
> position and length of terms. This information is then read back by the query \
> builder widget that uses it to syntax-highlight the queries. Other applications may \
> want to associate data with terms, for instance to pass hints to the search stores. \
>
> Diffs
> -----
>
> src/core/term.cpp ec98c4a
> src/core/term.h 23df3f1
>
> Diff: https://git.reviewboard.kde.org/r/117085/diff/
>
>
> Testing
> -------
>
> The code compiles and all the unit tests of Baloo pass ("make test" in the build \
> directory lists 12 passing tests)
>
> Thanks,
>
> Denis Steckelmacher
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117085/">https://git.reviewboard.kde.org/r/117085/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit e75f396a0ab9453c9d5c4550f5125542b2e009f2 by Denis Steckelmacher \
to branch KDE/4.13.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On March 26th, 2014, 1:45 p.m. UTC, Denis Steckelmacher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo.</div>
<div>By Denis Steckelmacher.</div>
<p style="color: grey;"><i>Updated March 26, 2014, 1:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds two methods in Baloo::Term: setUserData and userData. \
They can be used to associate arbitrary QVariants to terms. The data is not \
serialized to JSON nor read back when the term is deserialized.
The primary use of these two methods is to allow the user query parser to store the \
position and length of terms. This information is then read back by the query builder \
widget that uses it to syntax-highlight the queries. Other applications may want to \
associate data with terms, for instance to pass hints to the search stores.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The code compiles and all the unit tests of Baloo pass ("make \
test" in the build directory lists 12 passing tests)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/term.cpp <span style="color: grey">(ec98c4a)</span></li>
<li>src/core/term.h <span style="color: grey">(23df3f1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117085/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic