[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 116919: Bug Fix for bug 329039
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2014-03-21 12:16:50
Message-ID: 20140321121650.5895.43172 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116919/#review53639
-----------------------------------------------------------
Nice. We're fairly close now.
Please run baloo/src/file/autotests/metadatamovertest and check if it \
passes. The tests do not pass on my machine. See if you can figure it out, \
otherwise I can help :)
- Vishesh Handa
On March 21, 2014, 11:11 a.m., Nitul Datt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116919/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 11:11 a.m.)
>
>
> Review request for Baloo and Vishesh Handa.
>
>
> Bugs: 329039 and bug
> http://bugs.kde.org/show_bug.cgi?id=329039
> http://bugs.kde.org/show_bug.cgi?id=bug
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Removed the internal queue from metadatamover. Now, events are processed \
> as they arrive.
>
> Diffs
> -----
>
> src/file/updaterequest.h 1844dff
> src/file/updaterequest.cpp 63dd9c5
> src/file/CMakeLists.txt c5dba49
> src/file/metadatamover.h d7975ec
> src/file/metadatamover.cpp 14d454a
>
> Diff: https://git.reviewboard.kde.org/r/116919/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Nitul Datt
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116919/">https://git.reviewboard.kde.org/r/116919/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Nice. We're fairly close now.
Please run baloo/src/file/autotests/metadatamovertest and check if it \
passes. The tests do not pass on my machine. See if you can figure it out, \
otherwise I can help :)</pre> <br />
<p>- Vishesh Handa</p>
<br />
<p>On March 21st, 2014, 11:11 a.m. UTC, Nitul Datt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Nitul Datt.</div>
<p style="color: grey;"><i>Updated March 21, 2014, 11:11 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=329039">329039</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=bug">bug</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Removed the internal queue from metadatamover. Now, events are \
processed as they arrive.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/file/updaterequest.h <span style="color: \
grey">(1844dff)</span></li>
<li>src/file/updaterequest.cpp <span style="color: \
grey">(63dd9c5)</span></li>
<li>src/file/CMakeLists.txt <span style="color: \
grey">(c5dba49)</span></li>
<li>src/file/metadatamover.h <span style="color: \
grey">(d7975ec)</span></li>
<li>src/file/metadatamover.cpp <span style="color: \
grey">(14d454a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116919/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic