[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 116695: Fix conversion of value properties with CondEqual from Baloo::Term to Xap
From: Dan_Vrátil <dvratil () redhat ! com>
Date: 2014-03-12 10:19:20
Message-ID: 20140312101920.32099.7013 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116695/
-----------------------------------------------------------
(Updated March 12, 2014, 10:19 a.m.)
Status
------
This change has been marked as submitted.
Review request for Baloo, Laurent Montel and Vishesh Handa.
Repository: baloo
Description
-------
Right now the code in PimSearchStore::constructQuery() simply ignores == (CondEqual) \
operator for value properties (date, size, onlydate). This patch adds support for \
CondEqual operator for value properties and adds a unit tests for it (written by \
montel).
Diffs
-----
src/pim/akonadiplugin/autotests/searchplugintest.cpp 824da60
src/pim/search/pimsearchstore.cpp 7d208db
Diff: https://git.reviewboard.kde.org/r/116695/diff/
Testing
-------
Unit tests pass
Thanks,
Dan Vrátil
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116695/">https://git.reviewboard.kde.org/r/116695/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo, Laurent Montel and Vishesh Handa.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated March 12, 2014, 10:19 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Right now the code in PimSearchStore::constructQuery() simply ignores == \
(CondEqual) operator for value properties (date, size, onlydate). This patch adds \
support for CondEqual operator for value properties and adds a unit tests for it \
(written by montel).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Unit tests pass</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/pim/akonadiplugin/autotests/searchplugintest.cpp <span style="color: \
grey">(824da60)</span></li>
<li>src/pim/search/pimsearchstore.cpp <span style="color: \
grey">(7d208db)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116695/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic