'Review Request 116708: Support Akonadi instances in Baloo indexer'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Review Request 116708: Support Akonadi instances in Baloo indexer
From:       Dan_Vrátil <dvratil () redhat ! com>
Date:       2014-03-11 9:52:20
Message-ID: 20140311095220.18167.54171 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116708/
-----------------------------------------------------------

Review request for Baloo.

Repository: baloo

Description
-------

Use different Xapian databases for Baloo indexers running under differents Akonadi \
instances. The default Xapian databases are still stored in ~/.kde/share/apps/baloo/, \
but  when running under a different Akonadi instance, the indexer will use databases \
in ~/.kde/share/apps/baloo/instances/$AKONADI_INSTANCE/. Applications will also be \
able to search in these instance-specific databases when AKONADI_INSTANCE env \
variable is set.

This patch is purely for comfort of a certain Akonadi developer, who is using various \
Akonadi instances for testing and development and does not want to have data from \
devel instances indexed in the same database as data from his production instance. \
Applications like KRunner will only be able to search in the default databases \
(unless explicitely started with AKONADI_INSTANCE env set), but that is something the \
certain Akonadi developer is willing to live with. Akonadi instances are not used by \
normal users, so it will not affect them.

Diffs
-----

  src/pim/agent/agent.cpp 21efddf 
  src/pim/search/contact/CMakeLists.txt 3084b90 
  src/pim/search/contact/contactsearchstore.cpp d4d010e 
  src/pim/search/email/CMakeLists.txt a1ff2c9 
  src/pim/search/email/emailsearchstore.cpp fe7a42d 
  src/pim/search/note/CMakeLists.txt 9437952 
  src/pim/search/note/notesearchstore.cpp e0af291 
  src/pim/search/pimsearchstore.h cd13db4 
  src/pim/search/pimsearchstore.cpp 7d208db 

Diff: https://git.reviewboard.kde.org/r/116708/diff/

Testing
-------

Thanks,

Dan Vrátil

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116708/">https://git.reviewboard.kde.org/r/116708/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Baloo.</div>
<div>By Dan Vrátil.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use different Xapian databases for Baloo indexers running under \
differents Akonadi instances. The default Xapian databases are still stored in \
~/.kde/share/apps/baloo/, but  when running under a different Akonadi instance, the \
indexer will use databases in ~/.kde/share/apps/baloo/instances/$AKONADI_INSTANCE/. \
Applications will also be able to search in these instance-specific databases when \
AKONADI_INSTANCE env variable is set.

This patch is purely for comfort of a certain Akonadi developer, who is using various \
Akonadi instances for testing and development and does not want to have data from \
devel instances indexed in the same database as data from his production instance. \
Applications like KRunner will only be able to search in the default databases \
(unless explicitely started with AKONADI_INSTANCE env set), but that is something the \
certain Akonadi developer is willing to live with. Akonadi instances are not used by \
normal users, so it will not affect them.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/pim/agent/agent.cpp <span style="color: grey">(21efddf)</span></li>

 <li>src/pim/search/contact/CMakeLists.txt <span style="color: \
grey">(3084b90)</span></li>

 <li>src/pim/search/contact/contactsearchstore.cpp <span style="color: \
grey">(d4d010e)</span></li>

 <li>src/pim/search/email/CMakeLists.txt <span style="color: \
grey">(a1ff2c9)</span></li>

 <li>src/pim/search/email/emailsearchstore.cpp <span style="color: \
grey">(fe7a42d)</span></li>

 <li>src/pim/search/note/CMakeLists.txt <span style="color: \
grey">(9437952)</span></li>

 <li>src/pim/search/note/notesearchstore.cpp <span style="color: \
grey">(e0af291)</span></li>

 <li>src/pim/search/pimsearchstore.h <span style="color: grey">(cd13db4)</span></li>

 <li>src/pim/search/pimsearchstore.cpp <span style="color: \
grey">(7d208db)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116708/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 