'Re: Review Request 115287: Implement d-pointer safe assignment operator'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 115287: Implement d-pointer safe assignment operator
From:       "Christian Mollekopf" <chrigi_1 () fastmail ! fm>
Date:       2014-01-24 13:12:27
Message-ID: 20140124131227.10270.70110 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115287/
-----------------------------------------------------------

(Updated Jan. 24, 2014, 1:12 p.m.)

Status
------

This change has been marked as submitted.

Review request for Baloo.

Repository: baloo

Description
-------

Everything copyable with a d pointer needs an implementation of the
assignment operator.

Diffs
-----

  src/core/query.h 25106ff5a76410f89f37ae60c82fd475fd107af7 
  src/core/query.cpp bce53f655c29438c145c969e8f105982f27cc721 
  src/core/result.h e017d54493cf69c4a6c65f2c2d8fbb43216f6286 
  src/core/result.cpp e695b291d96a32b665f48ffcb9615722d8f41263 
  src/core/term.h cf1c81bbef57daa678b9b764bd5aa796a1e79510 
  src/core/term.cpp 4369ee50ec349de16f1b16ab9af45e086a88fe0c 

Diff: https://git.reviewboard.kde.org/r/115287/diff/

Testing
-------

Thanks,

Christian Mollekopf

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115287/">https://git.reviewboard.kde.org/r/115287/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Baloo.</div>
<div>By Christian Mollekopf.</div>

<p style="color: grey;"><i>Updated Jan. 24, 2014, 1:12 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Everything copyable with a d pointer needs an implementation of the \
assignment operator.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core/query.h <span style="color: \
grey">(25106ff5a76410f89f37ae60c82fd475fd107af7)</span></li>

 <li>src/core/query.cpp <span style="color: \
grey">(bce53f655c29438c145c969e8f105982f27cc721)</span></li>

 <li>src/core/result.h <span style="color: \
grey">(e017d54493cf69c4a6c65f2c2d8fbb43216f6286)</span></li>

 <li>src/core/result.cpp <span style="color: \
grey">(e695b291d96a32b665f48ffcb9615722d8f41263)</span></li>

 <li>src/core/term.h <span style="color: \
grey">(cf1c81bbef57daa678b9b764bd5aa796a1e79510)</span></li>

 <li>src/core/term.cpp <span style="color: \
grey">(4369ee50ec349de16f1b16ab9af45e086a88fe0c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115287/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 