'Re: Review Request 115267: SearchStore: Switch to QPluginLoader based plugins'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 115267: SearchStore: Switch to QPluginLoader based plugins
From:       "Christian Mollekopf" <chrigi_1 () fastmail ! fm>
Date:       2014-01-24 10:56:19
Message-ID: 20140124105619.10270.94565 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115267/
-----------------------------------------------------------

(Updated Jan. 24, 2014, 10:56 a.m.)

Status
------

This change has been marked as submitted.

Review request for Baloo.

Repository: baloo

Description
-------

SearchStore: Switch to QPluginLoader based plugins.

KPluginFactory calls KGlobal::locale() which crashes if it wasn't initialized
from the main thread of the program. In the case of akonadi (since akonadi is
a qt application), we can't initialize it, therefore we avoid it altoghether.

Diffs
-----

  src/core/searchstore.h c2363cc 
  src/core/searchstore.cpp 1a41e27 
  src/file/search/autotest/filesearchstoretest.cpp a01ef1d 
  src/file/search/filesearchstore.h bcdd1cd 
  src/file/search/filesearchstore.cpp f2a2ae4 
  src/pim/search/contact/contactsearchstore.h 9406e3b 
  src/pim/search/contact/contactsearchstore.cpp c7a4e11 
  src/pim/search/email/emailsearchstore.h 61f299c 
  src/pim/search/email/emailsearchstore.cpp 83f452c 

Diff: https://git.reviewboard.kde.org/r/115267/diff/

Testing
-------

Thanks,

Christian Mollekopf

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115267/">https://git.reviewboard.kde.org/r/115267/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Baloo.</div>
<div>By Christian Mollekopf.</div>

<p style="color: grey;"><i>Updated Jan. 24, 2014, 10:56 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">SearchStore: Switch to QPluginLoader based plugins.  
KPluginFactory calls KGlobal::locale() which crashes if it wasn&#39;t initialized
from the main thread of the program. In the case of akonadi (since akonadi is
a qt application), we can&#39;t initialize it, therefore we avoid it \
altoghether.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core/searchstore.h <span style="color: grey">(c2363cc)</span></li>

 <li>src/core/searchstore.cpp <span style="color: grey">(1a41e27)</span></li>

 <li>src/file/search/autotest/filesearchstoretest.cpp <span style="color: \
grey">(a01ef1d)</span></li>

 <li>src/file/search/filesearchstore.h <span style="color: \
grey">(bcdd1cd)</span></li>

 <li>src/file/search/filesearchstore.cpp <span style="color: \
grey">(f2a2ae4)</span></li>

 <li>src/pim/search/contact/contactsearchstore.h <span style="color: \
grey">(9406e3b)</span></li>

 <li>src/pim/search/contact/contactsearchstore.cpp <span style="color: \
grey">(c7a4e11)</span></li>

 <li>src/pim/search/email/emailsearchstore.h <span style="color: \
grey">(61f299c)</span></li>

 <li>src/pim/search/email/emailsearchstore.cpp <span style="color: \
grey">(83f452c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115267/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 