[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo
From: "Sune Vuorela" <kde () pusling ! com>
Date: 2014-01-16 9:05:24
Message-ID: 20140116090524.14108.34705 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 15, 2014, 9:17 a.m., Sune Vuorela wrote:
> > kdeui/kmessagewidgetdemo/CMakeLists.txt, line 23
> > <https://git.reviewboard.kde.org/r/114933/diff/2/?file=233694#file233694line23>
> >
> > Would it be hard to get rid of XmlGui here? I don't see what it really buy us for \
> > this example?
> > Replacing it with kwidgetaddons - and maybe switch from kmainwindow to \
> > qmainwindow will make the example simpler.
>
> Laurent Navet wrote:
> XmlGui replaced with KWidgetAddons and KConfigWidgets.
> switched from KMainWindow to QMainWindow.
I don't see the updated diff ?
- Sune
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114933/#review47428
-----------------------------------------------------------
On Jan. 10, 2014, 8:49 p.m., Laurent Navet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114933/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2014, 8:49 p.m.)
>
>
> Review request for KDE Examples and Sune Vuorela.
>
>
> Repository: kdeexamples
>
>
> Description
> -------
>
> This is part of Google Code-IN Contest.
> As I'm no more student, I've waited for the end of the contest to work on it.
>
> Comments appreciated,
>
>
> Diffs
> -----
>
> kdeui/kmessagewidgetdemo/CMakeLists.txt 12ef4ac
> kdeui/kmessagewidgetdemo/main.cpp d3a5bf0
> kdeui/kmessagewidgetdemo/window.h d3a67c8
> kdeui/kmessagewidgetdemo/window.cpp 9786da6
>
> Diff: https://git.reviewboard.kde.org/r/114933/diff/
>
>
> Testing
> -------
>
> Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit I've \
> commented the line.
>
> Thanks,
>
> Laurent Navet
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114933/">https://git.reviewboard.kde.org/r/114933/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 15th, 2014, 9:17 a.m. UTC, <b>Sune \
Vuorela</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114933/diff/2/?file=233694#file233694line23" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdeui/kmessagewidgetdemo/CMakeLists.txt</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">23</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">XmlGui</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Would it be hard to get \
rid of XmlGui here? I don't see what it really buy us for this example?
Replacing it with kwidgetaddons - and maybe switch from kmainwindow to qmainwindow \
will make the example simpler.</pre> </blockquote>
<p>On January 15th, 2014, 9:13 p.m. UTC, <b>Laurent Navet</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">XmlGui replaced with \
KWidgetAddons and KConfigWidgets. switched from KMainWindow to QMainWindow.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't \
see the updated diff ?</pre> <br />
<p>- Sune</p>
<br />
<p>On January 10th, 2014, 8:49 p.m. UTC, Laurent Navet wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Examples and Sune Vuorela.</div>
<div>By Laurent Navet.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2014, 8:49 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeexamples
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is part of Google Code-IN Contest. As I'm no more student, \
I've waited for the end of the contest to work on it.
Comments appreciated,</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Regression on KTextedit::setClickMessage(), as it don't exist in \
QTextEdit I've commented the line.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/kmessagewidgetdemo/CMakeLists.txt <span style="color: \
grey">(12ef4ac)</span></li>
<li>kdeui/kmessagewidgetdemo/main.cpp <span style="color: \
grey">(d3a5bf0)</span></li>
<li>kdeui/kmessagewidgetdemo/window.h <span style="color: \
grey">(d3a67c8)</span></li>
<li>kdeui/kmessagewidgetdemo/window.cpp <span style="color: \
grey">(9786da6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114933/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic